Merge lp:~zematynnad/rnr-server/api_check_856808 into lp:rnr-server
Proposed by
Danny Tamez
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Anthony Lenton | ||||||||
Approved revision: | 220 | ||||||||
Merged at revision: | 218 | ||||||||
Proposed branch: | lp:~zematynnad/rnr-server/api_check_856808 | ||||||||
Merge into: | lp:rnr-server | ||||||||
Diff against target: |
203 lines (+57/-61) 4 files modified
.bzrignore (+2/-1) fabtasks/bootstrap.py (+8/-1) src/reviewsapp/tests/test_utilities.py (+32/-24) src/reviewsapp/utilities.py (+15/-35) |
||||||||
To merge this branch: | bzr merge lp:~zematynnad/rnr-server/api_check_856808 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Nelson (community) | Approve | ||
Review via email: mp+100028@code.launchpad.net |
Commit message
Now calling sca's piston API for published apps.
Description of the change
Overview
=========
This branch switches to using SCA's piston api for retrieving applications.
Details
========
Now that SCA has this API available there is no need to call the view we were calling before. get_sca_
To Test
========
$fab bootstrap test
To post a comment you must log in.
Looks fine Danny. I'm assuming you looked at whether it was worth using the actual piston mini-client and decided against it for this one call?
Sheesh - I just checked the scaclient, and it's also using the old view-based available apps:
http:// bazaar. launchpad. net/~canonical- ca-hackers/ software- center/ scaclient/ view/head: /scaclient. py
for all api calls :/
In which case, it might be best to (1) update the scaclient to use the 2.0 api for all calls (it's tested in test_scaclient.py in sca), and then (2) update rnr to use the sca client? I think (1) is necessary, (2) is just a matter of us dogfooding our own tools - feel free to ignore (2) and land this branch as is, but given that scaclient is what where giving others to use (such as USC) I think we should update it asap. What do you think?