Merge lp:~zematynnad/rnr-server/active_passive_686547 into lp:rnr-server

[Danny Tamez]

Added a simple model to enable setting the moderation mode to active or passive from the admin site. Default is passive mode. When in active mode a review will automatically be flagged upon creation.

[lp:~zematynnad/rnr-server/active_passive_686547]

115. By Danny Tamez on 2011-01-27

Added missing spaces on a string.

[Michael Nelson (michael.nelson)]

Thanks Danny. The only necessary change is the assertions mentioned.

{{{
15:49 < zematynnad> noodles: achuni: mvo: would any of you have some time to look at
https://code.launchpad.net/~zematynnad/rnr-server/active_passive_686547/+merge/47719 ?
15:51 < noodles> zematynnad: Yep, I'll grab it now.
15:52 < zematynnad> thanks noodles
16:05 < noodles> Hey zematynnad, do you think it would make sense to do RNRSettings.is_active_mode() (or property) rather then RNRSettings.get_moderation_mode(). It would mean the callsite doesn't need to know about the settings? But either way, the code looks great.
16:13 < noodles> zematynnad: the only other thing is lines 316 and 335. AFAICT, you're really wanting to be asserting that the *value* of response_decoded['hide'] is False and True respectively, not that the key exists?
16:14 < zematynnad> noodles - I missed your first comment earlier - sure, I can change that
16:14 < noodles> zematynnad: only if you think it would improve the code - it was just a thought.
}}}

review: Approve

[lp:~zematynnad/rnr-server/active_passive_686547]

116. By Danny Tamez on 2011-01-28

Renamed get_moderation_mode to is_active_mode and returning bool
Tests for active and passive mode now check for value of hide.