Merge lp:~zeller-benjamin/ubuntu-ui-toolkit/qrcify2 into lp:ubuntu-ui-toolkit/staging

Proposed by Benjamin Zeller
Status: Work in progress
Proposed branch: lp:~zeller-benjamin/ubuntu-ui-toolkit/qrcify2
Merge into: lp:ubuntu-ui-toolkit/staging
Prerequisite: lp:~zeller-benjamin/ubuntu-ui-toolkit/qrcify
Diff against target: 79 lines (+15/-26)
5 files modified
src/Ubuntu/Components/Components.pro (+0/-1)
src/Ubuntu/Components/Styles/Styles.pro (+0/-15)
src/Ubuntu/Components/Styles/qmldir (+0/-10)
src/Ubuntu/Components/components.qrc (+6/-0)
src/Ubuntu/Components/plugin/plugin.cpp (+9/-0)
To merge this branch: bzr merge lp:~zeller-benjamin/ubuntu-ui-toolkit/qrcify2
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Zsombor Egri Needs Fixing
Review via email: mp+266373@code.launchpad.net

Commit message

- Move Styles module into the main Components plugin

Description of the change

- Move Styles module into the main Components plugin

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Looks good

review: Approve
Revision history for this message
Zsombor Egri (zsombi) wrote :

Needs some love :)

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1589. By Benjamin Zeller

Merge

1590. By Benjamin Zeller

Beautify

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1591. By Benjamin Zeller

Merge with qrcify

1592. By Benjamin Zeller

Fix package build

1593. By Benjamin Zeller

Rollback temporary changes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-autolanding/12/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-land-mp/12/console

review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-autolanding/27/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-land-mp/27/console

review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

1593. By Benjamin Zeller

Rollback temporary changes

1592. By Benjamin Zeller

Fix package build

1591. By Benjamin Zeller

Merge with qrcify

1590. By Benjamin Zeller

Beautify

1589. By Benjamin Zeller

Merge

1588. By Benjamin Zeller

Merge base branch

1587. By Benjamin Zeller

Merge staging

1586. By Benjamin Zeller

Merge staging

1585. By Benjamin Zeller

Merge with base branch

1584. By Benjamin Zeller

- Move Styles module into main plugin qrc

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Components/Components.pro'
--- src/Ubuntu/Components/Components.pro 2015-05-18 09:53:55 +0000
+++ src/Ubuntu/Components/Components.pro 2015-10-27 10:44:18 +0000
@@ -4,5 +4,4 @@
4 ComponentModule.pro \4 ComponentModule.pro \
5 Pickers \5 Pickers \
6 Popups \6 Popups \
7 Styles \
8 Themes7 Themes
98
=== removed file 'src/Ubuntu/Components/Styles/Styles.pro'
--- src/Ubuntu/Components/Styles/Styles.pro 2015-10-23 05:42:14 +0000
+++ src/Ubuntu/Components/Styles/Styles.pro 1970-01-01 00:00:00 +0000
@@ -1,15 +0,0 @@
1TARGETPATH = Ubuntu/Components/Styles
2
3ARTWORK_FILES = $$system(find artwork -type f)
4
5QML_FILES += 1.2/ComboButtonStyle.qml \
6 1.2/PageHeadStyle.qml \
7 1.2/PullToRefreshStyle.qml \
8 1.3/PageHeadStyle.qml \
9 1.3/ActionBarStyle.qml \
10 1.3/PageHeaderStyle.qml \
11 $$ARTWORK_FILES
12
13load(ubuntu_qml_module)
14
15OTHER_FILES+=qmldir
160
=== removed file 'src/Ubuntu/Components/Styles/qmldir'
--- src/Ubuntu/Components/Styles/qmldir 2015-10-08 21:19:56 +0000
+++ src/Ubuntu/Components/Styles/qmldir 1970-01-01 00:00:00 +0000
@@ -1,10 +0,0 @@
1module Ubuntu.Components.Styles
2ComboButtonStyle 1.1 1.2/ComboButtonStyle.qml
3PullToRefreshStyle 1.1 1.2/PullToRefreshStyle.qml
4PageHeadStyle 1.1 1.2/PageHeadStyle.qml
5
6#version 1.2 introduced by ListItemStyle
7#version 1.3
8PageHeadStyle 1.3 1.3/PageHeadStyle.qml
9ActionBarStyle 1.3 1.3/ActionBarStyle.qml
10PageHeaderStyle 1.3 1.3/PageHeaderStyle.qml
110
=== modified file 'src/Ubuntu/Components/components.qrc'
--- src/Ubuntu/Components/components.qrc 2015-10-27 10:44:18 +0000
+++ src/Ubuntu/Components/components.qrc 2015-10-27 10:44:18 +0000
@@ -125,5 +125,11 @@
125 <file>artwork/chevron@27.png</file>125 <file>artwork/chevron@27.png</file>
126 <file>artwork/delete@8.png</file>126 <file>artwork/delete@8.png</file>
127 <file>artwork/ListItemDivider6px@8.png</file>127 <file>artwork/ListItemDivider6px@8.png</file>
128 <file>Styles/1.2/ComboButtonStyle.qml</file>
129 <file>Styles/1.2/PageHeadStyle.qml</file>
130 <file>Styles/1.2/PullToRefreshStyle.qml</file>
131 <file>Styles/1.3/ActionBarStyle.qml</file>
132 <file>Styles/1.3/PageHeadStyle.qml</file>
133 <file>Styles/1.3/PageHeaderStyle.qml</file>
128 </qresource>134 </qresource>
129</RCC>135</RCC>
130136
=== modified file 'src/Ubuntu/Components/plugin/plugin.cpp'
--- src/Ubuntu/Components/plugin/plugin.cpp 2015-10-20 09:19:50 +0000
+++ src/Ubuntu/Components/plugin/plugin.cpp 2015-10-27 10:44:18 +0000
@@ -260,6 +260,15 @@
260 qmlRegisterType<UCListItemStyle>(styleUri, 1, 2, "ListItemStyle");260 qmlRegisterType<UCListItemStyle>(styleUri, 1, 2, "ListItemStyle");
261 qmlRegisterType<UCListItemStyle, 1>(styleUri, 1, 3, "ListItemStyle");261 qmlRegisterType<UCListItemStyle, 1>(styleUri, 1, 3, "ListItemStyle");
262262
263 //register styles
264 qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.2/ComboButtonStyle.qml"), styleUri, 1, 1, "ComboButtonStyle");
265 qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.2/PullToRefreshStyle.qml"), styleUri, 1, 1, "PullToRefreshStyle");
266 qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.2/PageHeadStyle.qml"), styleUri, 1, 1, "PageHeadStyle");
267
268 qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.3/PageHeadStyle.qml") , styleUri, 1, 3, "PageHeadStyle");
269 qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.3/ActionBarStyle.qml"), styleUri, 1, 3, "ActionBarStyle");
270 qmlRegisterType(QUrl("qrc:/Ubuntu/Components/Styles/1.3/PageHeaderStyle.qml"), styleUri, 1, 3, "PageHeaderStyle");
271
263 QQmlExtensionPlugin::initializeEngine(engine, uri);272 QQmlExtensionPlugin::initializeEngine(engine, uri);
264 QQmlContext* context = engine->rootContext();273 QQmlContext* context = engine->rootContext();
265274

Subscribers

People subscribed via source and target branches