Merge lp:~zeller-benjamin/ubuntu-sdk-ide/fix-for-qt56 into lp:ubuntu-sdk-ide

Proposed by Benjamin Zeller
Status: Merged
Approved by: Zoltan Balogh
Approved revision: no longer in the source branch.
Merged at revision: 126
Proposed branch: lp:~zeller-benjamin/ubuntu-sdk-ide/fix-for-qt56
Merge into: lp:ubuntu-sdk-ide
Diff against target: 88 lines (+20/-12)
3 files modified
CMakeLists.txt (+3/-7)
patch-qt.cmake (+3/-5)
patches/qt-enable-uitk.patch (+14/-0)
To merge this branch: bzr merge lp:~zeller-benjamin/ubuntu-sdk-ide/fix-for-qt56
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Zoltan Balogh Approve
Review via email: mp+289337@code.launchpad.net

Commit message

Fix build against Qt 5.6 and most recent UITK

Description of the change

Fix build against Qt 5.6 and most recent UITK

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
126. By Benjamin Zeller

Fix build against Qt 5.6 and most recent UITK.

Approved by ubuntu-sdk-build-bot, Zoltan Balogh.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2016-03-10 13:19:06 +0000
3+++ CMakeLists.txt 2016-03-17 10:08:25 +0000
4@@ -37,7 +37,7 @@
5 INSTALL_DIR "${QT_INSTALL_DIR}"
6 DOWNLOAD_COMMAND sh -c "bzr branch lp:~bzoltan/+junk/qt-everywhere-opensource-src-5.6.0 ${QT_SOURCE_DIR} -Ossl.cert_reqs=none --use-existing-dir"
7 UPDATE_COMMAND sh -c "exit 0"
8- PATCH_COMMAND sh -c "${CMAKE_COMMAND} -DQT_SOURCE_DIR=\"${QT_SOURCE_DIR}\" -P ${CMAKE_SOURCE_DIR}/patch-qt.cmake"
9+ PATCH_COMMAND sh -c "${CMAKE_COMMAND} -DQT_SOURCE_DIR=\"${QT_SOURCE_DIR}\" -DCMAKE_SOURCE_DIR=\"${CMAKE_SOURCE_DIR}\" -P ${CMAKE_SOURCE_DIR}/patch-qt.cmake"
10 CONFIGURE_COMMAND sh -c "${QT_SOURCE_DIR}/configure -prefix ${QT_INSTALL_DIR} `cat ${CMAKE_SOURCE_DIR}/qt5config`"
11 BUILD_COMMAND sh -c "make ${GENERATED_MAKE_FLAGS}"
12 INSTALL_COMMAND sh -c "make install"
13@@ -113,13 +113,9 @@
14 )
15
16 SET (QTCREATOR_PREFIX "${CMAKE_BINARY_DIR}/qtcreator-build")
17-ConcatStrings(QTC_DOWNLOAD_SCRIPT
18- "dget https://launchpad.net/ubuntu/+archive/primary/+files/qtcreator_3.5.0+dfsg-1ubuntu3.dsc "
19- "&& rsync -auvr --delete-after qtcreator-3.5.0+dfsg/ ${QTCREATOR_PREFIX}/qtcreator"
20-)
21 ConcatStrings(QTC_PATCH_SCRIPT
22 "cd ${QTCREATOR_PREFIX}/qtcreator "
23- "&& patch -p1 < ${CMAKE_SOURCE_DIR}/patches/qtc.patch "
24+ #"&& patch -p1 < ${CMAKE_SOURCE_DIR}/patches/qtc.patch "
25 "&& bzr branch lp:qtcreator-plugin-ubuntu ${QTCREATOR_PREFIX}/qtcreator/src/plugins/ubuntu -Ossl.cert_reqs=none "
26 "&& sed -i 's/\\(welcome\\)/\\1 \\\\ \\n ubuntu/g' ${QTCREATOR_PREFIX}/qtcreator/src/plugins/plugins.pro"
27 )
28@@ -130,7 +126,7 @@
29 SOURCE_DIR "${QTCREATOR_PREFIX}/qtcreator"
30 BINARY_DIR "${QTCREATOR_PREFIX}/build"
31 INSTALL_DIR "${CMAKE_BINARY_DIR}/ubuntu-sdk-ide"
32- DOWNLOAD_COMMAND sh -c "${QTC_DOWNLOAD_SCRIPT}"
33+ DOWNLOAD_COMMAND sh -c "cd ${QTCREATOR_PREFIX} && ${CMAKE_SOURCE_DIR}/get_package_source.py qtcreator"
34 PATCH_COMMAND sh -c "${QTC_PATCH_SCRIPT}"
35 CONFIGURE_COMMAND sh -c "${QT_INSTALL_DIR}/bin/qmake -r USE_SYSTEM_BOTAN=1 ${QTCREATOR_PREFIX}/qtcreator"
36 BUILD_COMMAND sh -c "QT_PRIVATE_HEADERS=${QT_INSTALL_DIR} LD_LIBRARY_PATH=${QT_INSTALL_DIR}/lib make ${GENERATED_MAKE_FLAGS}"
37
38=== modified file 'patch-qt.cmake'
39--- patch-qt.cmake 2016-03-17 08:15:07 +0000
40+++ patch-qt.cmake 2016-03-17 10:08:25 +0000
41@@ -1,8 +1,7 @@
42 if (NOT EXISTS "${QT_SOURCE_DIR}/qtfeedback")
43 EXECUTE_PROCESS(
44 WORKING_DIRECTORY "${QT_SOURCE_DIR}"
45- COMMAND sh -c "dget https://launchpad.net/ubuntu/+archive/primary/+files/qtfeedback-opensource-src_5.0~git20130529-0ubuntu12.dsc \\
46- && mv qtfeedback-opensource-src-* qtfeedback"
47+ COMMAND sh -c "${CMAKE_SOURCE_DIR}/get_package_source.py qtfeedback"
48 RESULT_VARIABLE command_result
49 )
50
51@@ -14,8 +13,7 @@
52 if (NOT EXISTS "${QT_SOURCE_DIR}/qtpim")
53 EXECUTE_PROCESS(
54 WORKING_DIRECTORY "${QT_SOURCE_DIR}"
55- COMMAND sh -c "dget https://launchpad.net/ubuntu/+archive/primary/+files/qtpim-opensource-src_5.0~git20140515~29475884-0ubuntu18.dsc \\
56- && mv qtpim-opensource-src-* qtpim"
57+ COMMAND sh -c "${CMAKE_SOURCE_DIR}/get_package_source.py qtpim"
58 RESULT_VARIABLE command_result
59 )
60
61@@ -29,7 +27,7 @@
62 WORKING_DIRECTORY "${QT_SOURCE_DIR}"
63 # COMMAND sh -c "bzr branch lp:ubuntu-ui-toolkit/staging ubuntu-sdk -Ossl.cert_reqs=none \\
64 COMMAND sh -c "bzr branch lp:~zeller-benjamin/ubuntu-ui-toolkit/qt56 ubuntu-sdk -Ossl.cert_reqs=none \\
65- && echo \"addModule(ubuntu-sdk,qtdeclarative qtfeedback qtpim)\" >> qt.pro \\
66+ && patch -p0 < ${CMAKE_SOURCE_DIR}/patches/qt-enable-uitk.patch \\
67 && mkdir -p ubuntu-sdk/.git"
68 RESULT_VARIABLE command_result
69 )
70
71=== added file 'patches/qt-enable-uitk.patch'
72--- patches/qt-enable-uitk.patch 1970-01-01 00:00:00 +0000
73+++ patches/qt-enable-uitk.patch 2016-03-17 10:08:25 +0000
74@@ -0,0 +1,14 @@
75+=== modified file '.gitmodules'
76+--- .gitmodules 2016-03-10 12:57:26 +0000
77++++ .gitmodules 2016-03-16 11:24:22 +0000
78+@@ -342,3 +342,9 @@
79+ branch = 5.6
80+ status = addon
81+ project = qmlcompiler.pro
82++[submodule "ubuntu-sdk"]
83++ depends = qtdeclarative qtfeedback qtpim
84++ path = ubuntu-sdk
85++ branch = 5.6
86++ status = addon
87++ project = ubuntu-sdk.pro
88+

Subscribers

People subscribed via source and target branches