Merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/bugfix2 into lp:qtcreator-plugin-ubuntu

Proposed by Benjamin Zeller
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 382
Merged at revision: 385
Proposed branch: lp:~zeller-benjamin/qtcreator-plugin-ubuntu/bugfix2
Merge into: lp:qtcreator-plugin-ubuntu
Prerequisite: lp:~zeller-benjamin/qtcreator-plugin-ubuntu/bugfix1
Diff against target: 45 lines (+7/-3)
2 files modified
share/qtcreator/ubuntu/qml/DevicesPage/DevicePage.qml (+2/-2)
src/ubuntu/wizards/ubuntufirstrunwizard.cpp (+5/-1)
To merge this branch: bzr merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/bugfix2
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zoltan Balogh Approve
Review via email: mp+258167@code.launchpad.net

Commit message

Show Desktop Kit in chroot setup page ( lp:1366934 lp:1369828)
Fix Bug lp:1400842 "devices panel: text says refresh but button is redetect"

Description of the change

Show Desktop Kit in chroot setup page ( lp:1366934 lp:1369828)

To post a comment you must log in.
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK

review: Approve
382. By Benjamin Zeller

Fix Bug lp:1400842 "devices panel: text says refresh but button is
redetect"

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'share/qtcreator/ubuntu/qml/DevicesPage/DevicePage.qml'
--- share/qtcreator/ubuntu/qml/DevicesPage/DevicePage.qml 2015-04-10 15:06:01 +0000
+++ share/qtcreator/ubuntu/qml/DevicesPage/DevicePage.qml 2015-05-04 12:31:18 +0000
@@ -307,7 +307,7 @@
307 }307 }
308 Button {308 Button {
309 id: deviceRedetectButton309 id: deviceRedetectButton
310 text: "Redetect"310 text: "Refresh"
311 onClicked: devicesModel.triggerRedetect(deviceId)311 onClicked: devicesModel.triggerRedetect(deviceId)
312 }312 }
313 }313 }
@@ -332,7 +332,7 @@
332 Layout.fillWidth: true332 Layout.fillWidth: true
333 }333 }
334 Button {334 Button {
335 text: "Redetect"335 text: "Refresh"
336 onClicked: devicesModel.triggerRedetect(deviceId)336 onClicked: devicesModel.triggerRedetect(deviceId)
337 }337 }
338 }338 }
339339
=== modified file 'src/ubuntu/wizards/ubuntufirstrunwizard.cpp'
--- src/ubuntu/wizards/ubuntufirstrunwizard.cpp 2015-05-04 12:31:18 +0000
+++ src/ubuntu/wizards/ubuntufirstrunwizard.cpp 2015-05-04 12:31:18 +0000
@@ -10,6 +10,7 @@
10#include <projectexplorer/kitmanager.h>10#include <projectexplorer/kitmanager.h>
11#include <projectexplorer/kitinformation.h>11#include <projectexplorer/kitinformation.h>
12#include <projectexplorer/devicesupport/devicemanager.h>12#include <projectexplorer/devicesupport/devicemanager.h>
13#include <projectexplorer/projectexplorerconstants.h>
1314
14#include <QLabel>15#include <QLabel>
15#include <QPushButton>16#include <QPushButton>
@@ -129,7 +130,10 @@
129 bool found = false;130 bool found = false;
130 foreach(ProjectExplorer::Kit *curr, allKits) {131 foreach(ProjectExplorer::Kit *curr, allKits) {
131 ProjectExplorer::ToolChain *tc = ProjectExplorer::ToolChainKitInformation::toolChain(curr);132 ProjectExplorer::ToolChain *tc = ProjectExplorer::ToolChainKitInformation::toolChain(curr);
132 if (tc->type() == QLatin1String(Constants::UBUNTU_CLICK_TOOLCHAIN_ID)) {133 const Core::Id devId = ProjectExplorer::DeviceKitInformation::deviceId(curr);
134
135 if (tc->type() == QLatin1String(Constants::UBUNTU_CLICK_TOOLCHAIN_ID) ||
136 devId == ProjectExplorer::Constants::DESKTOP_DEVICE_ID) {
133 found = true;137 found = true;
134138
135 QTreeWidgetItem* kitItem = new QTreeWidgetItem;139 QTreeWidgetItem* kitItem = new QTreeWidgetItem;

Subscribers

People subscribed via source and target branches