Merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/bugfix2 into lp:qtcreator-plugin-ubuntu

Proposed by Benjamin Zeller
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 382
Merged at revision: 385
Proposed branch: lp:~zeller-benjamin/qtcreator-plugin-ubuntu/bugfix2
Merge into: lp:qtcreator-plugin-ubuntu
Prerequisite: lp:~zeller-benjamin/qtcreator-plugin-ubuntu/bugfix1
Diff against target: 45 lines (+7/-3)
2 files modified
share/qtcreator/ubuntu/qml/DevicesPage/DevicePage.qml (+2/-2)
src/ubuntu/wizards/ubuntufirstrunwizard.cpp (+5/-1)
To merge this branch: bzr merge lp:~zeller-benjamin/qtcreator-plugin-ubuntu/bugfix2
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zoltan Balogh Approve
Review via email: mp+258167@code.launchpad.net

Commit message

Show Desktop Kit in chroot setup page ( lp:1366934 lp:1369828)
Fix Bug lp:1400842 "devices panel: text says refresh but button is redetect"

Description of the change

Show Desktop Kit in chroot setup page ( lp:1366934 lp:1369828)

To post a comment you must log in.
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK

review: Approve
382. By Benjamin Zeller

Fix Bug lp:1400842 "devices panel: text says refresh but button is
redetect"

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'share/qtcreator/ubuntu/qml/DevicesPage/DevicePage.qml'
2--- share/qtcreator/ubuntu/qml/DevicesPage/DevicePage.qml 2015-04-10 15:06:01 +0000
3+++ share/qtcreator/ubuntu/qml/DevicesPage/DevicePage.qml 2015-05-04 12:31:18 +0000
4@@ -307,7 +307,7 @@
5 }
6 Button {
7 id: deviceRedetectButton
8- text: "Redetect"
9+ text: "Refresh"
10 onClicked: devicesModel.triggerRedetect(deviceId)
11 }
12 }
13@@ -332,7 +332,7 @@
14 Layout.fillWidth: true
15 }
16 Button {
17- text: "Redetect"
18+ text: "Refresh"
19 onClicked: devicesModel.triggerRedetect(deviceId)
20 }
21 }
22
23=== modified file 'src/ubuntu/wizards/ubuntufirstrunwizard.cpp'
24--- src/ubuntu/wizards/ubuntufirstrunwizard.cpp 2015-05-04 12:31:18 +0000
25+++ src/ubuntu/wizards/ubuntufirstrunwizard.cpp 2015-05-04 12:31:18 +0000
26@@ -10,6 +10,7 @@
27 #include <projectexplorer/kitmanager.h>
28 #include <projectexplorer/kitinformation.h>
29 #include <projectexplorer/devicesupport/devicemanager.h>
30+#include <projectexplorer/projectexplorerconstants.h>
31
32 #include <QLabel>
33 #include <QPushButton>
34@@ -129,7 +130,10 @@
35 bool found = false;
36 foreach(ProjectExplorer::Kit *curr, allKits) {
37 ProjectExplorer::ToolChain *tc = ProjectExplorer::ToolChainKitInformation::toolChain(curr);
38- if (tc->type() == QLatin1String(Constants::UBUNTU_CLICK_TOOLCHAIN_ID)) {
39+ const Core::Id devId = ProjectExplorer::DeviceKitInformation::deviceId(curr);
40+
41+ if (tc->type() == QLatin1String(Constants::UBUNTU_CLICK_TOOLCHAIN_ID) ||
42+ devId == ProjectExplorer::Constants::DESKTOP_DEVICE_ID) {
43 found = true;
44
45 QTreeWidgetItem* kitItem = new QTreeWidgetItem;

Subscribers

People subscribed via source and target branches