Merge lp:~zeller-benjamin/qtcreator-plugin-remotelinux/upstreamchanges into lp:qtcreator-plugin-remotelinux

Proposed by Benjamin Zeller
Status: Merged
Merged at revision: 10
Proposed branch: lp:~zeller-benjamin/qtcreator-plugin-remotelinux/upstreamchanges
Merge into: lp:qtcreator-plugin-remotelinux
Diff against target: 31 lines (+4/-5)
2 files modified
src/remotelinux/abstractremotelinuxrunconfiguration.h (+0/-5)
src/remotelinux/remotelinuxrunconfiguration.h (+4/-0)
To merge this branch: bzr merge lp:~zeller-benjamin/qtcreator-plugin-remotelinux/upstreamchanges
Reviewer Review Type Date Requested Status
Zoltan Balogh Approve
Review via email: mp+215824@code.launchpad.net

Commit message

Changes required to merge upstream

Description of the change

Changed that were required to merge upstream

To post a comment you must log in.
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/remotelinux/abstractremotelinuxrunconfiguration.h'
--- src/remotelinux/abstractremotelinuxrunconfiguration.h 2014-04-09 10:50:27 +0000
+++ src/remotelinux/abstractremotelinuxrunconfiguration.h 2014-04-15 08:32:30 +0000
@@ -53,12 +53,7 @@
53 virtual QString remoteExecutableFilePath() const = 0;53 virtual QString remoteExecutableFilePath() const = 0;
54 virtual QStringList arguments() const = 0;54 virtual QStringList arguments() const = 0;
55 virtual QString workingDirectory() const = 0;55 virtual QString workingDirectory() const = 0;
56 virtual QString alternateRemoteExecutable() const = 0;
57 virtual bool useAlternateExecutable() const = 0;
58 virtual Utils::Environment environment() const = 0;56 virtual Utils::Environment environment() const = 0;
59signals:
60 void deploySpecsChanged();
61 void targetInformationChanged() const;
6257
63protected:58protected:
64 AbstractRemoteLinuxRunConfiguration(ProjectExplorer::Target *parent,59 AbstractRemoteLinuxRunConfiguration(ProjectExplorer::Target *parent,
6560
=== modified file 'src/remotelinux/remotelinuxrunconfiguration.h'
--- src/remotelinux/remotelinuxrunconfiguration.h 2014-03-20 13:39:22 +0000
+++ src/remotelinux/remotelinuxrunconfiguration.h 2014-04-15 08:32:30 +0000
@@ -90,6 +90,10 @@
9090
91 static const char *IdPrefix;91 static const char *IdPrefix;
9292
93signals:
94 void deploySpecsChanged();
95 void targetInformationChanged() const;
96
93protected:97protected:
94 RemoteLinuxRunConfiguration(ProjectExplorer::Target *parent,98 RemoteLinuxRunConfiguration(ProjectExplorer::Target *parent,
95 RemoteLinuxRunConfiguration *source);99 RemoteLinuxRunConfiguration *source);

Subscribers

People subscribed via source and target branches