Merge lp:~zeller-benjamin/kubuntu-packaging/qtcreator-ubuntudevice-qmlprojects2 into lp:~kubuntu-packagers/kubuntu-packaging/qtcreator

Proposed by Benjamin Zeller
Status: Merged
Merged at revision: 141
Proposed branch: lp:~zeller-benjamin/kubuntu-packaging/qtcreator-ubuntudevice-qmlprojects2
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/qtcreator
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/patches/qmlproject_allow_ubuntudevice.diff (+1/-1)
To merge this branch: bzr merge lp:~zeller-benjamin/kubuntu-packaging/qtcreator-ubuntudevice-qmlprojects2
Reviewer Review Type Date Requested Status
Zoltan Balogh Pending
Review via email: mp+229237@code.launchpad.net

Commit message

Fix qmlproject patch to match all ubuntudevice subtypes

Description of the change

Fix qmlproject patch to match all ubuntudevice subtypes

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-07-29 15:46:11 +0000
+++ debian/changelog 2014-08-01 14:03:02 +0000
@@ -1,3 +1,9 @@
1qtcreator (3.1.1-0ubuntu4) utopic; urgency=medium
2
3 * Change patch to enable ubuntu device in plain QML projects, to match all Ubuntu device subtypes
4
5 -- Benjamin Zeller <benjamin.zeller@canonical.com> Fri, 01 Aug 2014 13:55:35 +0200
6
1qtcreator (3.1.1-0ubuntu3) utopic; urgency=medium7qtcreator (3.1.1-0ubuntu3) utopic; urgency=medium
28
3 * Add patch to enable ubuntu devices for plain QML projects in QtCreator9 * Add patch to enable ubuntu devices for plain QML projects in QtCreator
410
=== modified file 'debian/patches/qmlproject_allow_ubuntudevice.diff'
--- debian/patches/qmlproject_allow_ubuntudevice.diff 2014-07-29 11:32:57 +0000
+++ debian/patches/qmlproject_allow_ubuntudevice.diff 2014-08-01 14:03:02 +0000
@@ -16,7 +16,7 @@
16 Id deviceType = ProjectExplorer::DeviceTypeKitInformation::deviceTypeId(k);16 Id deviceType = ProjectExplorer::DeviceTypeKitInformation::deviceTypeId(k);
17- if (deviceType != ProjectExplorer::Constants::DESKTOP_DEVICE_TYPE) {17- if (deviceType != ProjectExplorer::Constants::DESKTOP_DEVICE_TYPE) {
18+ if (deviceType != ProjectExplorer::Constants::DESKTOP_DEVICE_TYPE &&18+ if (deviceType != ProjectExplorer::Constants::DESKTOP_DEVICE_TYPE &&
19+ deviceType != "UbuntuProjectManager.DeviceTypeId") {19+ !deviceType.toString().startsWith(QStringLiteral("UbuntuProjectManager.DeviceTypeId"))) {
20 if (errorMessage)20 if (errorMessage)
21 *errorMessage = tr("Device type is not desktop.");21 *errorMessage = tr("Device type is not desktop.");
22 return false;22 return false;

Subscribers

People subscribed via source and target branches