Merge lp:~zeitgeist/zeitgeist/symbols into lp:~zeitgeist/zeitgeist/bluebird
Proposed by
Seif Lotfy
Status: | Merged |
---|---|
Merged at revision: | 73 |
Proposed branch: | lp:~zeitgeist/zeitgeist/symbols |
Merge into: | lp:~zeitgeist/zeitgeist/bluebird |
Diff against target: |
144 lines (+118/-0) 3 files modified
src/Makefile.am (+1/-0) src/ontology.vala (+116/-0) src/zeitgeist-daemon.vala (+1/-0) |
To merge this branch: | bzr merge lp:~zeitgeist/zeitgeist/symbols |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Needs Fixing | ||
Siegfried Gevatter | Needs Fixing | ||
Review via email: mp+69927@code.launchpad.net |
Description of the change
Symbols class for generating symbols that will be used later for Interpretation and Manifestation
To post a comment you must log in.
- /* datamodel.vala
ontology
- public static HashTable<string, Symbol> SymbolsCollection = null;
rename all_symbols, put it into Symbol (it's static), make it private
- displayName, allChildren
display_name, all_children
- why are you messing with GenericArray< ->List? (parents, etc.)
they're the same, so use just one
- doesn't work when it isn't a direct parent.
you need to lookup the parent in all_symbols (formerly SymbolsCollection)
then iterate over its all_children
- make the constructor private and let register take the uri/name/etc and
instantiate (later we'll also hide register in some way, eg. making it
protected).
- we need a "static Symbol from_uri(sting uri)" which returns lookup( uri)".
"all_symbols.