Zeitgeist Framework

Code review comment for lp:~zeitgeist/zeitgeist/fts++

  1. fts++
  2. Merge into bluebird
Revision history for this message
Siegfried Gevatter (rainct) wrote :

OK, merging it, but there's some outstanding stuff:

 * Important: the TableLookup in FTS can currently explode. The new schema version needs to add AUTOINCREMENT to the `id' row of all tables in TableLookup. We should do this before releasing a new tarball.

 * TableLookup.get_value: please prepare the query in the constructor.

 * Configure isn't checking for xapian being there

 * Add a flag to disable FTS? (keeping the Xapian dependency avoidable)

review: Approve

« Back to merge proposal