Merge lp:~zeitgeist/zeitgeist/fix-592599-subject-AND into lp:zeitgeist/0.1
Proposed by
Markus Korn
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 1526 | ||||
Proposed branch: | lp:~zeitgeist/zeitgeist/fix-592599-subject-AND | ||||
Merge into: | lp:zeitgeist/0.1 | ||||
Diff against target: |
167 lines (+63/-46) 3 files modified
_zeitgeist/engine/main.py (+47/-39) test/engine-test.py (+12/-1) test/remote-test.py (+4/-6) |
||||
To merge this branch: | bzr merge lp:~zeitgeist/zeitgeist/fix-592599-subject-AND | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen | diff and run unit tests | Approve | |
Zeitgeist Framework Team | Pending | ||
Review via email: mp+30920@code.launchpad.net |
Commit message
Changing the connector of subjects in a query template from OR to AND
Description of the change
This branch changes the connector of subjects in a template from "OR" to "AND", so a template like
(*event_metadata, [subject1, subject2])
does not expand to
*event_metadata AND (subject1 or subject2)
anymore, but now it's
*event_metadata AND subject1 AND subject2
(the connector for the metadata of an event is still AND)
To post a comment you must log in.
Looks good and all the tests are passing on my end. Good work Markus!