Code review comment for lp:~zeitgeist/zeitgeist/find_events

Revision history for this message
Siegfried Gevatter (rainct) wrote :

FindEventIds is great for complex use cases, especially interfaces involving pagination (as we discussed in Bolzano), but for simple queries or uses like in the GNOME Activity Journal, where all data is requested at once (whatever the number of events there are), it's really only in the way, by forcing an additional SQL query and D-Bus request.

Considering that SQLite and D-Bus are what take most of the time in a request, we should avoid those as much as possible. This branch implements the few necessary changes in engine/ to implement this; additions to client.py can follow once it's merged.

« Back to merge proposal