Code review comment for lp:~zeitgeist/activity-log-manager/smaller-exclude-icons

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Ah, I didn't read the bug report, sorry.

I think that for consistency, icons in this list should be laid out exactly the same way as icons in menu items are. That does mean they should be smaller. However, Rico is right that that wouldn't actually fix the vertical alignment of the text. In the screenshot, the text for the previous-sized folder icons is too high, but the text for the newly-sized application icons is too low. It should be vertically centered, just like text in menu items.

« Back to merge proposal