I believe there might also be a second bug - in oxide::ContentMainDelegate::PreSandboxStartup we call ui::ResourceBundle::InitSharedInstanceWithLocale with an empty locale to rely on Chromium to select the correct locale (and load the right resource file, which is needed to get the correct Accept-Language header). But this only works when Chromium is built with the glib bits turned on, which I don't think we do anymore. If that's the case, we also need to pass the application locale to InitSharedInstanceWithLocale (it would mean adding a second method - PlatformDelegate::GetApplicationLocale - in addition to the one added in this merge).
Thanks, this looks fine.
I believe there might also be a second bug - in oxide:: ContentMainDele gate::PreSandbo xStartup we call ui::ResourceBun dle::InitShared InstanceWithLoc ale with an empty locale to rely on Chromium to select the correct locale (and load the right resource file, which is needed to get the correct Accept-Language header). But this only works when Chromium is built with the glib bits turned on, which I don't think we do anymore. If that's the case, we also need to pass the application locale to InitSharedInsta nceWithLocale (it would mean adding a second method - PlatformDelegat e::GetApplicati onLocale - in addition to the one added in this merge).
Would you mind taking a look at that too?