Code review comment for lp:~ywwg/mixxx/features_xwax2
Revision history for this message
| RAFFI TEA (raffitea) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> > BPM values of +- 0.4
>
> These aren't outliers, you're just seeing how much wow/flutter your turntable
> actually has (I'm already smoothing the values anyway).
>
> Enough people have mentioned this issue that it's probably worth addressing.
> I've added QTimers in the display widgets that update the BPM displays every
> 1/4th second. I'd like to strike a balance between updating too fast and too
> slow.
Hey Owen,
I am really thankful that BPM updates every 1/4th second. The BPM display is much better to read but it is still not perfectly to read for me. I really recommend to build the average BPM for every time interval. Traktor uses a similar approach which I think is pretty useful to find the perfect pitch position faster.
If you think it is not usefully maybe you can direct me to the code so I can implement for my own :-)
Again, thanks for your awesome work!
Tobias