Code review comment for lp:~yuningdodo/usb-creator/usb-creator.lp1325801v2-sync-syslinux-c32-files

Hi Mathieu,

Sorry for the late update. Unfortunately the patch doesn't work when host system is 14.10 and target system is 14.04. It will report an error that some other c32 files are missing. However even if we modify the patch to copy all the host c32 files to target it still doesn't work as expected. It does show the menu, but in a very low resolution (maybe 20x10 ?), and no text is displayed. We can still operate blindly, such as press F6 to show the boot args menu, the menu can be popped in a low resolution, you just can't see any text.

In such a case I would rather reject this patch and propose another merge request with https://launchpadlibrarian.net/194872381/use-source-syslinux.patch , you can see a simple compare between these two patches here: https://bugs.launchpad.net/ubuntu/+source/usb-creator/+bug/1325801/comments/92 . I'll make some tests and propose the request later.

Or maybe we should use different solutions for <=14.04 and >=14.10 ?