Code review comment for lp:~yuningdodo/usb-creator/usb-creator.lp1325801-sync-syslinux-c32-files

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Could you please resubmit these changes a against lp:~usb-creator-hackers/usb-creator/trunk?

I'm not sure this is going to fix things for writing pre-14.10 images using a 14.10 system; the files are now split into directories which probably ought to be taken into account as well. By my initial testing, just copying the directory or the files over in syslinux/ directly don't seem to fix this, but it also only affects non-EFI boots.

You've tested writing various images from trusty. Have you also tested writing, for example, a trusty image from utopic, to see if the resulting image can be properly booted?

review: Needs Fixing

« Back to merge proposal