Ubuntu
squid3 package

Code review comment for lp:~yolanda.robla/ubuntu/trusty/squid3/add_distribution

  1. Trusty (14.04)
  2. add_distribution
  3. Merge into trusty
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

configure diff is huge due to version missmatch, if one uses matching autoconf (2.68 in this case) then the diff would be smaller. But it's ok.

I see:
941 ++# define distribution
942 ++if test -x /usr/bin/lsb_release && lsb_release -si; then
943 ++ SQUID_DISTRIBUTION="$(lsb_release -si)"
944 ++else
945 ++ SQUID_DISTRIBUTION=""
946 ++fi
947 ++
948 ++cat >>confdefs.h <<_ACEOF
949 ++#define SQUID_DISTRIBUTION "$SQUID_DISTRIBUTION"
950 ++_ACEOF

Can you please still patch configure.ac none-the-less? Such that next time one does regenerate configure from configure.ac that change is not accidentally lost.

review: Needs Fixing

« Back to merge proposal