Merge lp:~yolanda.robla/ubuntu/trusty/nodejs/add_distribution into lp:ubuntu/trusty/nodejs

Proposed by Yolanda Robla
Status: Work in progress
Proposed branch: lp:~yolanda.robla/ubuntu/trusty/nodejs/add_distribution
Merge into: lp:ubuntu/trusty/nodejs
Diff against target: 97 lines (+34/-2)
7 files modified
.pc/applied-patches (+1/-0)
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/fix_distribution.patch (+21/-0)
debian/patches/series (+1/-0)
node.gyp (+1/-0)
src/node_version.h (+1/-1)
To merge this branch: bzr merge lp:~yolanda.robla/ubuntu/trusty/nodejs/add_distribution
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+197507@code.launchpad.net

Description of the change

  * debian/patches/fix_distribution.patch: show version in nodejs
  * debian/control: added lsb-release as build dependency

To post a comment you must log in.
35. By Yolanda Robla

added trusty distribution

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Yet again, this change is too minor to carry it as an Ubuntu-specific patch, please forward it upstream (or at least get an ACK from upstream about that).

Also, “UBUNTU_DISTRIBUTION” is a bad name for variable, as this patch will work on Debian and any other Linux release.

−1 from me.

Revision history for this message
Iain Lane (laney) wrote :

Please respond once you've heard back from Debian - setting to WIP

Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

Unmerged revisions

35. By Yolanda Robla

added trusty distribution

34. By Yolanda Robla

* debian/patches/fix_distribution.patch: show version in nodejs
* debian/control: added lsb-release as build dependency

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.pc/applied-patches'
--- .pc/applied-patches 2013-11-30 23:54:20 +0000
+++ .pc/applied-patches 2013-12-03 12:23:15 +0000
@@ -9,3 +9,4 @@
91003_test_disable_chunked_response.patch91003_test_disable_chunked_response.patch
101004_test_writeNaN.patch101004_test_writeNaN.patch
111005_unbreak_bsd_builds.patch111005_unbreak_bsd_builds.patch
12fix_distribution.patch
1213
=== modified file 'debian/changelog'
--- debian/changelog 2013-11-30 23:54:20 +0000
+++ debian/changelog 2013-12-03 12:23:15 +0000
@@ -1,3 +1,10 @@
1nodejs (0.10.22~dfsg1-2ubuntu1) trusty; urgency=low
2
3 * debian/patches/fix_distribution.patch: show version in nodejs
4 * debian/control: added lsb-release as build dependency
5
6 -- Yolanda Robla <yolanda.robla@canonical.com> Tue, 03 Dec 2013 12:56:36 +0100
7
1nodejs (0.10.22~dfsg1-2) unstable; urgency=low8nodejs (0.10.22~dfsg1-2) unstable; urgency=low
29
3 * Update 2005 patch, allow test-cluster-dgram-2 to time out.10 * Update 2005 patch, allow test-cluster-dgram-2 to time out.
411
=== modified file 'debian/control'
--- debian/control 2013-08-14 00:16:46 +0000
+++ debian/control 2013-12-03 12:23:15 +0000
@@ -20,7 +20,8 @@
20 python,20 python,
21 libv8-3.14-dev (>= 3.7),21 libv8-3.14-dev (>= 3.7),
22 libssl-dev (>= 1.0.0g),22 libssl-dev (>= 1.0.0g),
23 libc-ares-dev (>= 1.7.5)23 libc-ares-dev (>= 1.7.5),
24 lsb-release
24Standards-Version: 3.9.425Standards-Version: 3.9.4
25Homepage: http://nodejs.org/26Homepage: http://nodejs.org/
26Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/nodejs.git27Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/nodejs.git
2728
=== added file 'debian/patches/fix_distribution.patch'
--- debian/patches/fix_distribution.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/fix_distribution.patch 2013-12-03 12:23:15 +0000
@@ -0,0 +1,21 @@
1--- a/node.gyp 2013-12-03 11:50:27.741880000 +0000
2+++ b/node.gyp 2013-12-03 11:55:02.162386103 +0000
3@@ -144,6 +144,7 @@
4 'ARCH="<(target_arch)"',
5 'PLATFORM="<(OS)"',
6 'NODE_TAG="<(node_tag)"',
7+ 'UBUNTU_DISTRIBUTION="<!(lsb_release -si)"'
8 ],
9
10 'conditions': [
11--- a/src/node_version.h 2013-12-03 11:50:27.741880000 +0000
12+++ b/src/node_version.h 2013-12-03 12:05:31.774386103 +0000
13@@ -49,7 +49,7 @@
14 NODE_TAG "-pre"
15 #endif
16
17-#define NODE_VERSION "v" NODE_VERSION_STRING
18+#define NODE_VERSION "v" NODE_VERSION_STRING " (" UBUNTU_DISTRIBUTION ")"
19
20
21 #define NODE_VERSION_AT_LEAST(major, minor, patch) \
022
=== modified file 'debian/patches/series'
--- debian/patches/series 2013-11-30 23:54:20 +0000
+++ debian/patches/series 2013-12-03 12:23:15 +0000
@@ -9,3 +9,4 @@
91003_test_disable_chunked_response.patch91003_test_disable_chunked_response.patch
101004_test_writeNaN.patch101004_test_writeNaN.patch
111005_unbreak_bsd_builds.patch111005_unbreak_bsd_builds.patch
12fix_distribution.patch
1213
=== modified file 'node.gyp'
--- node.gyp 2013-07-28 18:50:13 +0000
+++ node.gyp 2013-12-03 12:23:15 +0000
@@ -144,6 +144,7 @@
144 'ARCH="<(target_arch)"',144 'ARCH="<(target_arch)"',
145 'PLATFORM="<(OS)"',145 'PLATFORM="<(OS)"',
146 'NODE_TAG="<(node_tag)"',146 'NODE_TAG="<(node_tag)"',
147 'UBUNTU_DISTRIBUTION="<!(lsb_release -si)>"'
147 ],148 ],
148149
149 'conditions': [150 'conditions': [
150151
=== modified file 'src/node_version.h'
--- src/node_version.h 2013-11-13 23:17:51 +0000
+++ src/node_version.h 2013-12-03 12:23:15 +0000
@@ -49,7 +49,7 @@
49 NODE_TAG "-pre"49 NODE_TAG "-pre"
50#endif50#endif
5151
52#define NODE_VERSION "v" NODE_VERSION_STRING52#define NODE_VERSION "v" NODE_VERSION_STRING " (" UBUNTU_DISTRIBUTION ")"
5353
5454
55#define NODE_VERSION_AT_LEAST(major, minor, patch) \55#define NODE_VERSION_AT_LEAST(major, minor, patch) \

Subscribers

People subscribed via source and target branches

to all changes: