Code review comment for lp:~yolanda.robla/ubuntu/saucy/bind9/server_banner

Revision history for this message
James Page (james-page) wrote :

Hi Yolanda

Quick question - is this correct?

54 +if test -x /usr/bin/lsb_release; then
55 + BIND9_DISTRIBUTION="BIND9_DISTRIBUTION=$(lsb_release -si)"
56 +else

The inclusion of BIND9_DISTRIBUTION= within the "" looked odd to me?

review: Needs Information

« Back to merge proposal