Code review comment for lp:~yolanda.robla/ubuntu/precise/nova/essex-sru

Revision history for this message
James Page (james-page) wrote :

Yolanda

The only problem I can see is with the changelog:

=== modified file 'debian/changelog'
--- debian/changelog 2012-12-17 10:39:28 +0000
+++ debian/changelog 2012-12-18 11:53:10 +0000
@@ -1,8 +1,7 @@
 nova (2012.1.4+stable-20121217-9f277e38-0ubuntu1) precise-proposed; urgency=low

   [ Chuck Short ]
- * debian/*.logrotate: compress logfiles when they are rotated. (LP:
- #1049915)
+ * debian/*.logrotate: compress logfiles when they are rotated. (LP: #1049915)

   [ Yolanda Robla Mota ]
   * Resynchronize with stable/essex (9f277e38):
@@ -43,7 +42,7 @@
     - [ae280ca] Deleted floating ips can cause instance delete to fail
       (LP: #1038266)

- -- Adam Gandelman <email address hidden> Mon, 27 Aug 2012 14:50:40 -0700
+ -- Adam Gandelman <email address hidden> Mon, 27 Aug 2012 14:50:40 -0700

 nova (2012.1.3+stable-20120824-86fb7362-0ubuntu1) precise-proposed; urgency=low

The bug reference needs to be in a single line and Adam's email address has been truncated.

Fix that up and this branch looks good to go.

review: Needs Fixing

« Back to merge proposal