Merge lp:~yolanda.robla/horizon/autokpgtests into lp:~ubuntu-server-dev/horizon/havana

Proposed by Yolanda Robla
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~yolanda.robla/horizon/autokpgtests
Merge into: lp:~ubuntu-server-dev/horizon/havana
Diff against target: 47 lines (+18/-0)
4 files modified
debian/changelog (+8/-0)
debian/control (+1/-0)
debian/tests/control (+3/-0)
debian/tests/test_python_django_horizon (+6/-0)
To merge this branch: bzr merge lp:~yolanda.robla/horizon/autokpgtests
Reviewer Review Type Date Requested Status
Yolanda Robla (community) Needs Resubmitting
James Page Needs Fixing
Review via email: mp+182168@code.launchpad.net

Description of the change

Added autopkg tests

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

Two comments

1) needs-root - not in this case

2) why not just execute the python directly

"""
#!/usr/bin/python

import horizon

print "Imported horizon django module OK"
"""

If the import fails then the return code will be non-zero - removes the need for the bash wrapper.

review: Needs Fixing
Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

please recheck

165. By Yolanda Robla

removed needs-root, not using wrapper for tests

Revision history for this message
James Page (james-page) wrote :

Hey Yolanda

Tests execute OK - but please can you add an entry to the changelog!

Thanks!

review: Needs Fixing
166. By Yolanda Robla

added autopkg tests:
debian/control: added XS-Testsuite
debian/tests: added test files

Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

ok, added it

review: Needs Resubmitting

Unmerged revisions

166. By Yolanda Robla

added autopkg tests:
debian/control: added XS-Testsuite
debian/tests: added test files

165. By Yolanda Robla

removed needs-root, not using wrapper for tests

164. By Yolanda Robla

added autopkg tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-08-21 14:08:37 +0000
3+++ debian/changelog 2013-08-28 15:06:28 +0000
4@@ -1,3 +1,11 @@
5+horizon (1:2013.2~b2-0ubuntu4) saucy; urgency=low
6+
7+ * added autopkg tests:
8+ debian/control: added XS-Testsuite
9+ debian/tests: added test files
10+
11+ -- Yolanda <yolanda.robla@canonical.com> Wed, 28 Aug 2013 17:02:04 +0200
12+
13 horizon (1:2013.2~b2-0ubuntu3) saucy; urgency=low
14
15 * debian/rules: Don't remove egg information while cleaning.
16
17=== modified file 'debian/control'
18--- debian/control 2013-07-22 18:36:36 +0000
19+++ debian/control 2013-08-28 15:06:28 +0000
20@@ -17,6 +17,7 @@
21 Homepage: http://launchpad.net/horizon
22 Vcs-Browser: http://bazaar.launchpad.net/~ubuntu-server-dev/horizon/havana/files
23 Vcs-Bzr: https://code.launchpad.net/~ubuntu-server-dev/horizon/havana
24+XS-Testsuite: autopkgtest
25
26 Package: python-django-horizon
27 Section: python
28
29=== added directory 'debian/tests'
30=== added file 'debian/tests/control'
31--- debian/tests/control 1970-01-01 00:00:00 +0000
32+++ debian/tests/control 2013-08-28 15:06:28 +0000
33@@ -0,0 +1,3 @@
34+Tests: test_python_django_horizon
35+Depends: python-django-horizon
36+
37
38=== added file 'debian/tests/test_python_django_horizon'
39--- debian/tests/test_python_django_horizon 1970-01-01 00:00:00 +0000
40+++ debian/tests/test_python_django_horizon 2013-08-28 15:06:28 +0000
41@@ -0,0 +1,6 @@
42+#!/usr/bin/python
43+#-------------------------
44+# Testing client utilities
45+#-------------------------
46+import horizon
47+print "Imported horizon django module OK"

Subscribers

People subscribed via source and target branches