Juju Charms Collection
keystone package

Code review comment for lp:~yolanda.robla/charms/precise/keystone/unit_testing

  1. Precise Pangolin (12.04)
  2. unit_testing
  3. Merge into icehouse
Revision history for this message
James Page (james-page) wrote :

Looking better; one further comment - Mocks don't have an "assert_called()" method; this works because its a mock but actually fails to check anything - use :

   self.assertTrue(self.<function>.called).

I see a few instances of this throughout the tests.

review: Needs Fixing

« Back to merge proposal