Code review comment for lp:~yohanboniface/ubuntu-calendar-app/fix1279933

Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks for the patch Yohan! I tested it and it seems to fix the issue, nice job.

Looking at the bug report, you were looking at writing tests. The calendar application has two types of tests:

 - unit tests that essentially test the helpers in dateExt.js
 - autopilot tests that test the UI and user interaction (they’re more like integration tests)

For this specific issue, I guess we could write both types of tests, but a good start would be to add a unit test for the new endOfDay() function. You can do that by adding a test to tests/unittests/tst_date.qml.
To execute the unit tests, just run:

    cmake .
    ctest -V

I’m approving as anyways it is good to be merged as is, the tests would be a nice addition but not strictly necessary.

review: Approve

« Back to merge proposal