Code review comment for lp:~yohanboniface/ubuntu-calendar-app/AgendaView

Revision history for this message
Michael Hall (mhall119) wrote :

It seems the example given in DetailFilter is incorrect. From what I can tell, the "Type" component doesn't exist, but the "Detail" component has the same properties and would make sense to assign to the 'detail' property of DetailFilter. Also there is no Type enum, but ItemType seems to contain the value used in the example. So maybe something like this:

    Detail {
        id: typeDetailToMatch
        type: ItemType.Todo
    }
    DetailFilter {
        id: todoFilter
        detail: typeDetailToMatch
    }

« Back to merge proposal