Ubuntu Calendar App

Code review comment for lp:~yohanboniface/ubuntu-calendar-app/AgendaView

  1. AgendaView
  2. Merge into trunk
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

I missed something in original comment,

        var timeFormat = i18n.tr("hh:mm");
        var startTime = e.startDateTime.toLocaleTimeString(Qt.locale(), timeFormat);
        var endTime = e.endDateTime.toLocaleTimeString(Qt.locale(), timeFormat);

I was suggested to use i18n.tr() instead of qsTr(), and format date/time as shown in above code.

but I am not able to figure out how to use i18n.tr from using from JS.
How about using code similar to above from QML directly for now ?
and then take help from some expert for how to move formating code to JS lib and use i18n.tr from JS,

« Back to merge proposal