Which you already did, I have no further comment there.
But, you are creating a Page and putting AgendaView ( which is also a page) inside this page, which is not necessary.
+ page: Page {
125 + anchors.fill: parent
126 + tools: commonToolBar
127 + AgendaView {
so, I think we can directly put AgendaView inside tab, instead of creating intermediate page. Like
> Oh, you're right. But then what was you expecting me to do with this comment: /code.launchpad .net/~yohanboni face/ubuntu- calendar- +merge/ 212164/ comments/ 501716 ?
> https:/
> app/AgendaView/
so, I wanted to you make root element of AgendaView a Page.
12 +Page {
13 + id: root
14 + objectName: "AgendaView"
Which you already did, I have no further comment there.
But, you are creating a Page and putting AgendaView ( which is also a page) inside this page, which is not necessary.
+ page: Page {
125 + anchors.fill: parent
126 + tools: commonToolBar
127 + AgendaView {
so, I think we can directly put AgendaView inside tab, instead of creating intermediate page. Like
+ Tab {
tools: commonToolBar
/ / and rest of necessary properties
}
122 + objectName: "agendaTab"
123 + title: i18n.tr("Agenda")
124 + page: AgendaView {