Code review comment for lp:~yohanboniface/ubuntu-calendar-app/AgendaView

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

145 +Date.prototype.formatTime = function (d) {
146 + // TRANSLATORS: this is a time formatting string,
147 + // see http://qt-project.org/doc/qt-5.0/qtqml/qml-qtquick2-date.html#details for valid expressions
148 + var format = qsTr("hh:mm");
149 + return Qt.formatTime(this, format);
150 +}

I was suggested to use following for time date translation, can you also use the same.

        var startTime = e.startDateTime.toLocaleTimeString(Qt.locale(), timeFormat);
        var endTime = e.endDateTime.toLocaleTimeString(Qt.locale(), timeFormat);

BTW above code is from EventDetails.

« Back to merge proposal