Code review comment for lp:~yohanboniface/ubuntu-calendar-app/AgendaView

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

+ Component.onCompleted: {
44 + model = GlobalModel.gloablModel();
45 + model.reloaded.connect(buildList);
46 + }

As we are loading whole year's events using buildList, I suspect there will be performance problem, might hang UI if there are many events.

I think for this case it might be better to use separate OrganizerModel for agenda view, then you will not need to populate model your self and also it will not rebuild model in case of addition or deletion of event.

But I need to consult EDS developer for the same.

« Back to merge proposal