Code review comment for lp:~yellow/testrepository/on_filter

Revision history for this message
Gary Poster (gary) wrote :

I…don't know. It is one way to get your subunit tag filter branch to not cause test failures with testrepository. The only reason this branch, of one like it would not be necessary is if Robert's branch fixed it *and* it landed before yours.

I personally suggest that you all land the two on_filter branches of something like them that replaces dependency on _filtered, and then land your subunit-filter with tags branch, which has been proven to work as we'd like, at least. Robert's branch isn't ready to land, and these are, afaik.

« Back to merge proposal