Merge lp:~yellow/subunit/test-count into lp:~subunit/subunit/trunk
Proposed by
Gary Poster
Status: | Rejected |
---|---|
Rejected by: | Robert Collins |
Proposed branch: | lp:~yellow/subunit/test-count |
Merge into: | lp:~subunit/subunit/trunk |
Diff against target: |
101 lines (+15/-10) 2 files modified
python/subunit/test_results.py (+12/-0) python/subunit/tests/test_subunit_filter.py (+3/-10) |
To merge this branch: | bzr merge lp:~yellow/subunit/test-count |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonathan Lange | Disapprove | ||
Review via email: mp+103717@code.launchpad.net |
Description of the change
This branch changes the semantics of testsRun in a TestResultFilter to count the total number of tests run, not the number of tests filtered.
Whether these semantics are correct is up for debate. We're obviously proposing that they are. That said, these changes primarily exist to make the testrepository change in lp:~yellow/testrepository/bug988481 cleaner. We don't know how to continue to subclass in testrepository.
This is work done by Benji York and Brad Crittenden; I'm just helping out with the MP.
To post a comment you must log in.
Unmerged revisions
- 164. By Benji York
-
make filtered test results report the total number of tests
I'm not 100% sure about this change, but I can't think of any actual use case for which this would be a regression.