Merge lp:~yann-papouin/ocb-addons/6.1-bug-1260778-sale-date-confirm into lp:ocb-addons/6.1

Proposed by Yann Papouin
Status: Merged
Merged at revision: 6825
Proposed branch: lp:~yann-papouin/ocb-addons/6.1-bug-1260778-sale-date-confirm
Merge into: lp:ocb-addons/6.1
Diff against target: 21 lines (+2/-2)
1 file modified
sale/sale.py (+2/-2)
To merge this branch: bzr merge lp:~yann-papouin/ocb-addons/6.1-bug-1260778-sale-date-confirm
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Sandy Carter (http://www.savoirfairelinux.com) code review, no test Approve
Guewen Baconnier @ Camptocamp code review Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+199486@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks for the patch!

review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Thanks.
Same as the OPW patch https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-587363-ado/+merge/153063
Who is the author? If Amit Dodiya is, it would have been better if you committed with --author attributed to Amit.

review: Approve (code review)
Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) :
review: Approve (code review, no test)
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

we can give the credits also at merge time

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'sale/sale.py'
--- sale/sale.py 2013-11-20 01:17:39 +0000
+++ sale/sale.py 2013-12-18 15:47:54 +0000
@@ -756,7 +756,7 @@
756 return {756 return {
757 'name': pick_name,757 'name': pick_name,
758 'origin': order.name,758 'origin': order.name,
759 'date': order.date_order,759 'date': order.date_confirm,
760 'type': 'out',760 'type': 'out',
761 'state': 'auto',761 'state': 'auto',
762 'move_type': order.picking_policy,762 'move_type': order.picking_policy,
@@ -822,7 +822,7 @@
822 if line.state == 'done':822 if line.state == 'done':
823 continue823 continue
824824
825 date_planned = self._get_date_planned(cr, uid, order, line, order.date_order, context=context)825 date_planned = self._get_date_planned(cr, uid, order, line, order.date_confirm, context=context)
826826
827 if line.product_id:827 if line.product_id:
828 if line.product_id.product_tmpl_id.type in ('product', 'consu'):828 if line.product_id.product_tmpl_id.type in ('product', 'consu'):

Subscribers

People subscribed via source and target branches