Code review comment for lp:~yamahata/nova/boot-from-volume-1

Revision history for this message
Sandy Walsh (sandy-walsh) wrote :

Impressive branch. I don't have a set up for testing it in depth, so I can't verify correctness.

I would like to see mocked out unit tests for each new method/function. Many of the _ internal methods have no tests at all.

Minor things:
+379/380 ... commented out?
+405 ... potential black hole?

review: Needs Fixing

« Back to merge proposal