Code review comment for lp:~yamahata/nova/boot-from-volume-0

Revision history for this message
Rick Harris (rconradharris) wrote :

> ======================================================================
> FAIL: test_stop_with_attached_volume (nova.tests.test_cloud.CloudTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/rick/openstack/nova/boot-from-volume-0/nova/tests/test_cloud.py", line 691, in
> test_stop_with_attached_volume
> self._assert_volume_attached(vol, instance_id, '/dev/vdc')
> File "/home/rick/openstack/nova/boot-from-volume-0/nova/tests/test_cloud.py", line 582, in >_assert_volume_attached
> self.assertEqual(vol['mountpoint'], mountpoint)
> AssertionError: u'\\/dev\\/vdc' != '/dev/vdc'

Turns out this was caused by running an older version of carrot (0.10.3) which didn't handle escaping properly.

Upgrading to 0.10.5 fixed it.

Patch looks great, nice job.

review: Approve

« Back to merge proposal