Code review comment for lp:~yamahata/glance/lp802883

Revision history for this message
Jay Pipes (jaypipes) wrote :

> Hey Jay, I'm aware that pre-requisites work, but are co-dependent branches
> allowed? Basically Branch A depends on Branch B *and* Branch B depends on
> Branch A?

Gotcha, sorry, I misunderstood...

> https://code.launchpad.net/~yamahata/glance/lp802883/+merge/66092
> https://code.launchpad.net/~yamahata/glance/lp802885/+merge/66093
> https://code.launchpad.net/~yamahata/glance/lp802878/+merge/66090
>
> These three changes don't fix anything individually, but as a whole they seem
> to make run_tests.sh work? Maybe I'm an outlier here, but since this branch
> doesn't actually fix anything (as in, this line of code doesn't make anything
> *work* that I can tell), I'd rather have 1 branch than 3...in this case.

Yes, I would prefer a single branch containing all three bug fixes...

-jay

« Back to merge proposal