Code review comment for lp:~yamahata/glance/lp802883

Revision history for this message
Isaku Yamahata (yamahata) wrote :

On Wed, Jun 29, 2011 at 04:45:58PM -0000, Brian Lamar wrote:
> Hey, I'm on board with your other changes, but I'm not certain that they make sense separately. Maybe they do and I just don't understand :) Can you give me a command I can run right now that this specific proposal will make work?

All three fixes are necessary to make 'test_run.sh --pudb --pudb-failure'
work. So each single patch doesn't make sense separately.
I'm quite fine with putting three patches into single branch and marking
other two report invalid as long as the fixes are accepted.

I reported three bugs separately just because they're logically
different and it would help code review. But you don't think so.
--
yamahata

« Back to merge proposal