Code review comment for lp:~yajo/duplicity/duplicity
Revision history for this message
| Yajo (yajo) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi there, concerns 1 and 3 fixed.
About number 2, the problem is that I really need this patch in 0.7 because I'm hitting bug #1823858 it in production, whereas 0.8 is not yet released. This is half feature half bugfix, but TBH what motivated me most to push the MR is the bugfix.
I thought that a good approach would be to add the feature but disable it by default (as I did) in 0.7, but in 0.8 we could default to the partial sync mode because, as you say, it is has most benefits.
Or can you think a better solution?