Merge ~ya-bo-ng/maas:min-ram-label into maas:master

Proposed by Anthony Dillon
Status: Merged
Approved by: Anthony Dillon
Approved revision: a238fb9be9ebf2e198a6758eb3de9002a4c43e1e
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ya-bo-ng/maas:min-ram-label
Merge into: maas:master
Diff against target: 13 lines (+1/-1)
1 file modified
src/maasserver/static/partials/pod-details.html (+1/-1)
Reviewer Review Type Date Requested Status
Bartek Szopka (community) Approve
Barry McGee (community) Approve
Steve Rydz (community) Approve
Review via email: mp+367630@code.launchpad.net

Commit message

Correct unit labelling when composing machine

Description of the change

Update the size label to state MB over GB when composing a machine

To post a comment you must log in.
Revision history for this message
Barry McGee (barry-mcgee) wrote :

LGTM

Revision history for this message
Steve Rydz (steverydz) wrote :

LGTM +1

review: Approve
Revision history for this message
Barry McGee (barry-mcgee) :
review: Approve
Revision history for this message
Bartek Szopka (bartoszopka) wrote :

LGTM

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/pod-details.html b/src/maasserver/static/partials/pod-details.html
2index bb34204..cbb4b0a 100644
3--- a/src/maasserver/static/partials/pod-details.html
4+++ b/src/maasserver/static/partials/pod-details.html
5@@ -67,7 +67,7 @@
6 options="arch for arch in pod.architectures" data-ng-if="pod.architectures.length > 1" label-width="2" label-width-tablet="2" input-width="3" input-width-tablet="4"></maas-obj-field>
7 <maas-obj-field type="text" key="cores" label="Minimum Cores" subtle="false" placeholder="Number of cores (optional)" subtle-text="{$ availableWithOvercommit(pod.total.cores, pod.used.cores, pod.cpu_over_commit_ratio, 1) $} cores available" label-width="2" label-width-tablet="2" input-width="3" input-width-tablet="4"></maas-obj-field>
8 <maas-obj-field type="text" key="cpu_speed" label="Minimum Speed (MHz)" subtle="false" placeholder="CPU speed (optional)" subtle-text="{$ pod.hints.cpu_speed $}MHz maximum" label-width="2" label-width-tablet="2" input-width="3" input-width-tablet="4"></maas-obj-field>
9- <maas-obj-field type="text" key="memory" label="Minimum RAM (GB)" subtle="false" placeholder="Memory amount (optional)" subtle-text="{$ availableWithOvercommit(pod.total.memory_gb, pod.used.memory_gb, pod.memory_over_commit_ratio, 1) $}GB available" label-width="2" label-width-tablet="2" input-width="3" input-width-tablet="4"></maas-obj-field>
10+ <maas-obj-field type="text" key="memory" label="Minimum RAM (MB)" subtle="false" placeholder="Memory amount (optional)" subtle-text="{$ availableWithOvercommit(pod.total.memory_gb, pod.used.memory_gb, pod.memory_over_commit_ratio, 1) $}GB available" label-width="2" label-width-tablet="2" input-width="3" input-width-tablet="4"></maas-obj-field>
11 </div>
12 </div>
13 <div class="p-strip">

Subscribers

People subscribed via source and target branches