Merge ~ya-bo-ng/maas:remove-entire-dnsresource into maas:master

[Anthony Dillon]

LP: #1817674 - Completely remove the DNS resource when deleting from the UI

Remove the entire DNS resource when deleting via the UI instead of just the IP addresses.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b remove-entire-dnsresource lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 4697bb59439f83d036b29e82d1b16c1451b8b6b1

review: Approve

[Steve Rydz (steverydz)]

LGTM +1

review: Approve

[Alberto Donato (ack)]

change looks good but could you please also add a test for it?

[Anthony Dillon (ya-bo-ng)]

Thanks Alberto, added a few tests for the deleteDNSRecord method.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b remove-entire-dnsresource lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: cabef6771aa15eadaa5f136bf2a918574a2047e6

review: Approve

[Alberto Donato (ack)]

+1, thanks for the added tests

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b remove-entire-dnsresource lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/5275/consoleText

diff --git a/src/maasserver/static/js/angular/factories/domains.js b/src/maasserver/static/js/angular/factories/domains.js
index 5a9537f..355c917 100644
--- a/src/maasserver/static/js/angular/factories/domains.js
+++ b/src/maasserver/static/js/angular/factories/domains.js
@@ -71,7 +71,7 @@ angular.module('MAAS').factory(
             if(record.rrtype === 'A' || record.rrtype === 'AAAA') {
                 record.ip_addresses = record.rrdata.split(/[ ,]+/);
                 return RegionConnection.callMethod(
-                    "domain.delete_address_record", record);
+                    "domain.delete_dnsresource", record);
             } else {
                 return RegionConnection.callMethod(
                     "domain.delete_dnsdata", record);
diff --git a/src/maasserver/static/js/angular/factories/tests/test_domains.js b/src/maasserver/static/js/angular/factories/tests/test_domains.js
index 920c12c..8c5823c 100644
--- a/src/maasserver/static/js/angular/factories/tests/test_domains.js
+++ b/src/maasserver/static/js/angular/factories/tests/test_domains.js
@@ -135,6 +135,41 @@ describe("DomainsManager", function() {
         });
     });
 
+    describe("deleteDNSRecord", function() {
+        it("calls delete_dnsresource for A record", function() {
+            spyOn(RegionConnection, "callMethod");
+            var record = {
+                'rrtype': 'A',
+                'rrdata': '192.168.0.1'
+            };
+            DomainsManager.deleteDNSRecord(record);
+            expect(RegionConnection.callMethod).toHaveBeenCalledWith(
+                "domain.delete_dnsresource", record);
+        });
+
+        it("calls delete_dnsresource for AAAA record", function() {
+            spyOn(RegionConnection, "callMethod");
+            var record = {
+                'rrtype': 'AAAA',
+                'rrdata': '2001:db8::1, 10.0.0.1 127.0.0.1'
+            };
+            DomainsManager.deleteDNSRecord(record);
+            expect(RegionConnection.callMethod).toHaveBeenCalledWith(
+                "domain.delete_dnsresource", record);
+        });
+
+        it("calls update_dnsdata for other types", function() {
+            spyOn(RegionConnection, "callMethod");
+            var record = {
+                'rrtype': 'SRV'
+            };
+            DomainsManager.deleteDNSRecord(record);
+            expect(RegionConnection.callMethod).toHaveBeenCalledWith(
+                "domain.delete_dnsdata", record);
+        });
+
+    });
+
     describe("getDomainByName", function() {
         it("returns null when no domains", function() {
             expect(DomainsManager.getDomainByName('meh')).toBe(null);