MAAS

Merge ~ya-bo-ng/maas:form-improves-labels into maas:master

  1. Git
  2. lp:~ya-bo-ng/maas
  3. form-improves-labels
  4. Merge into master
Proposed by Anthony Dillon
Status: Merged
Approved by: Anthony Dillon
Approved revision: 95c7d97bc20494eb3f12dd00f04653af9d7ea033
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ya-bo-ng/maas:form-improves-labels
Merge into: maas:master
Diff against target: 879 lines (+187/-164)
13 files modified
src/maasserver/static/js/angular/directives/power_parameters.js (+39/-38)
src/maasserver/static/js/angular/directives/tests/test_power_parameters.js (+3/-3)
src/maasserver/static/js/angular/factories/tests/test_zones.js (+0/-1)
src/maasserver/static/partials/dashboard.html (+7/-7)
src/maasserver/static/partials/domain-details.html (+6/-6)
src/maasserver/static/partials/fabric-details.html (+9/-9)
src/maasserver/static/partials/node-details.html (+14/-5)
src/maasserver/static/partials/node-result.html (+6/-6)
src/maasserver/static/partials/subnet-details.html (+46/-42)
src/maasserver/static/partials/vlan-details.html (+30/-28)
src/maasserver/static/partials/zone-details.html (+8/-14)
src/maasserver/static/scss/_patterns_forms.scss (+14/-0)
src/maasserver/templates/maasserver/user_view.html (+5/-5)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Lilyana Videnova (community) Approve
Review via email: mp+363353@code.launchpad.net

Commit message

Muted uneditable form labels

Description of the change

Slightly mute the styling of form field labels when they are not editable to make the data more clear.

Uneditable:
https://user-images.githubusercontent.com/1413534/53012452-eb2f3d80-343a-11e9-8639-4b8998142e90.png

Editable:
https://user-images.githubusercontent.com/1413534/53012480-f84c2c80-343a-11e9-8166-021c3dc249e7.png

To post a comment you must log in.
~ya-bo-ng/maas:form-improves-labels updated
d8467c4... by Anthony Dillon

Catch a few missing labels

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b form-improves-labels lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/5104/console
COMMIT: fa36611341fb5b55558254925c8c29b48e7f0917

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b form-improves-labels lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/5105/console
COMMIT: fbae2bdc1ba63815aa7b87977120225af10b3bb6

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b form-improves-labels lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/5120/console
COMMIT: 405503ae30037080d3cb8575d5ff4914823a3028

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b form-improves-labels lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 18ac912d64ebb64a6837892c30b69c14b27d3324

review: Approve
Revision history for this message
Lilyana Videnova (lilyanavidenova) wrote :

lgtm!

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b form-improves-labels lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/5129/console
COMMIT: dd6bd32b4154323accc20385e12e6049dd48d1ee

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b form-improves-labels lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/5137/console
COMMIT: d8467c4b401cfa92ad1d2f90b935cf5c366e9505

review: Needs Fixing
~ya-bo-ng/maas:form-improves-labels updated
95c7d97... by Anthony Dillon

Test CI again

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b form-improves-labels lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 95c7d97bc20494eb3f12dd00f04653af9d7ea033

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches