Merge ~ya-bo-ng/maas:update-footer-logo-height into maas:master

Proposed by Anthony Dillon
Status: Merged
Approved by: Anthony Dillon
Approved revision: ee56aa1e1850c66a090213e2596a303ffe7825b2
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ya-bo-ng/maas:update-footer-logo-height
Merge into: maas:master
Diff against target: 13 lines (+2/-1)
1 file modified
src/maasserver/static/scss/_patterns_footer.scss (+2/-1)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Steve Rydz (community) Approve
Review via email: mp+361091@code.launchpad.net

Commit message

Update the footer logo height

Description of the change

Updated the footer logo to match the design review comments.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b update-footer-logo-height lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 54c967df2ac77f5e1b3a2cc7df99f3a44edf9ecc

review: Approve
Revision history for this message
Steve Rydz (steverydz) wrote :

LGTM +1

but please remove the build.css file

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b update-footer-logo-height lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: ee56aa1e1850c66a090213e2596a303ffe7825b2

review: Approve
Revision history for this message
Lyubomir Popov (lyubomir-popov) wrote :

perfect thanks

Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/scss/_patterns_footer.scss b/src/maasserver/static/scss/_patterns_footer.scss
2index 7f8189a..b7eb1fd 100644
3--- a/src/maasserver/static/scss/_patterns_footer.scss
4+++ b/src/maasserver/static/scss/_patterns_footer.scss
5@@ -3,7 +3,8 @@
6 margin-top: auto;
7
8 &__logo {
9- margin: 0.5rem 1rem;
10+ margin: 0.5rem 0;
11+ height: 1rem;
12 }
13 }
14

Subscribers

People subscribed via source and target branches