Code review comment for ~ya-bo-ng/maas:kvm-storage-pods-landing-view

Revision history for this message
Caleb Ellis (caleb-ellis) wrote :

- I get an angular error: TypeError: Cannot read property 'storage_pools' of null at Scope.$scope.getDefaultStoragePool. If I go back a couple of commits it works.

- How many different locations or storage configurations can we expect? It's already pretty close to the bottom of my viewport, and with it attached to a sticky header it's possible for content to become unreachable. Maybe we can remove sticky when the header is expanded?

- Other comments inline

review: Needs Fixing

« Back to merge proposal