Code review comment for ~ya-bo-ng/maas:kvm-storage-pods-landing-view

Revision history for this message
Martin Storey (cassiocassio) wrote :

Following a call... notes:

8 GB mininimum check?
compose machine button grey and warning around capacity field?

default should be selected
“name (default)” shuold be be shown

tick align with name of pool?
spacing of green tick - not wide enough
tick should be black chosen tick not green success tick

love the “impossible to remove the boot partition” function… check with team nobody has a good reason to make unbootable machines, you never know

it’s big pulldown, but still a pulldown -
- single click to open - stays open
- click and drag - stays open, unike a system pulldown
- click to select an item, selects that pool, AND closes
- moving focus, e.g. tab to tags field, also closes…
- HOWEVER clicking on capacity

Capacity field is a number so should be input type="number”>

escape key to close dropdown
mouseover on cross rectangular - square would make more visual sense

focus to tags should close

consider: alighing used key to left and putting close X top right?

what happens when there are 10 pools to pick from, or 20?
max depth and clipping and autoscroll

clicking + to add another row needs to close any open dropdown?

handle multiple requests to the same pool in the same compose dialog with “other” colour and o+o in the key…
https://zpl.io/2j4v7GQ

« Back to merge proposal