MAAS

Code review comment for ~ya-bo-ng/maas:replace-ga-with-gtm

  1. Git
  2. lp:~ya-bo-ng/maas
  3. replace-ga-with-gtm
  4. Merge into master
Revision history for this message
Blake Rouse (blake-rouse) wrote :

This issue is now you will not get new page views. The code you removed updated the current page even in a SPA, which MAAS mostly is (only some settings pages are not).

The reason this was linked to angular code is because of this:

$rootScope.$on('$routeChangeSuccess', function() {});

This is called when the HTML5 route is changed, something that you are completely losing with your change.

review: Needs Fixing

« Back to merge proposal