Merge ~ya-bo-ng/maas:subnets-in-interfaces into maas:master

Proposed by Anthony Dillon
Status: Merged
Approved by: Anthony Dillon
Approved revision: fc91cf6e250ec2bf12517065979e2160a4403022
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ya-bo-ng/maas:subnets-in-interfaces
Merge into: maas:master
Diff against target: 12 lines (+1/-0)
1 file modified
src/maasserver/static/partials/node-details.html (+1/-0)
Reviewer Review Type Date Requested Status
Newell Jensen (community) Approve
MAAS Lander Approve
Review via email: mp+343141@code.launchpad.net

Commit message

LP: #1763216 - Reinstate subnet data in interfaces table

Description of the change

Go to interfaces tab in node details
Behold the subnet data

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b subnets-in-interfaces lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: fc91cf6e250ec2bf12517065979e2160a4403022

review: Approve
Revision history for this message
Newell Jensen (newell-jensen) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/node-details.html b/src/maasserver/static/partials/node-details.html
2index 05c3c6a..72eb87a 100755
3--- a/src/maasserver/static/partials/node-details.html
4+++ b/src/maasserver/static/partials/node-details.html
5@@ -1048,6 +1048,7 @@
6 <span data-ng-if="!isEditing(interface)">{$ getVLANText(interface.vlan) $}</span>
7 </td>
8 <td class="table-col--13" aria-label="Subnet">
9+ <span data-ng-if="!isEditing(interface) && ((isDevice && interface.subnet) || (interface.fabric && !interface.discovered[0].subnet_id))">{$ getSubnetText(interface.subnet) $}</span>
10 <span data-ng-if="isAllNetworkingDisabled() && interface.discovered[0].subnet_id">
11 {$ getSubnetText(getSubnet(interface.discovered[0].subnet_id)) $}
12 </span>

Subscribers

People subscribed via source and target branches