Merge ~ya-bo-ng/maas:pods-empty-state into maas:master

Proposed by Anthony Dillon
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 4f696638867deee8eebe6187965598f113c0e078
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ya-bo-ng/maas:pods-empty-state
Merge into: maas:master
Diff against target: 58 lines (+21/-22)
1 file modified
src/maasserver/static/partials/pods-list.html (+21/-22)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
MAAS Lander unittests Pending
Review via email: mp+340128@code.launchpad.net

Commit message

LP: #1751900 - Align the empty pod list

Description of the change

## Done
Updated the empty pod list mark up to look like it did originally

## QA
- Go pods list
- Delete all pods
- See that it looks like it originally did

Fixes https://bugs.launchpad.net/maas/+bug/1751900

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/pods-list.html b/src/maasserver/static/partials/pods-list.html
2index ad32f82..4f1e6b3 100644
3--- a/src/maasserver/static/partials/pods-list.html
4+++ b/src/maasserver/static/partials/pods-list.html
5@@ -84,32 +84,31 @@
6 <maas-notifications></maas-notifications>
7 </div>
8 <div class="row">
9- <div class="col-12">
10+ <div class="col-12 u-align--center">
11 <div data-ng-if="!loading && pods.length == 0" class="p-heading-icon">
12- <div class="p-heading-icon__header">
13- <svg class="p-heading-icon__img" width="85px" height="104px" viewBox="0 0 85 104" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
14- <title>add-pod</title>
15- <defs></defs>
16- <g id="Pod-creation" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
17- <g id="003_Pod---empty-state" transform="translate(-677.000000, -320.000000)">
18- <g id="Empty-state" transform="translate(337.000000, 320.000000)">
19- <g id="add-pod" transform="translate(340.000000, 0.000000)">
20- <path d="M42.2502469,126.44299 L42.2502469,42.4025859" id="path4205" stroke="#888888" stroke-width="4" transform="translate(42.774938, 84.422788) rotate(-90.000000) translate(-42.774938, -84.422788) "></path>
21- <path d="M50.6453086,78.1197576 L35.9539506,78.1197576" id="path4207" stroke="#888888" stroke-width="4" transform="translate(43.299630, 78.645010) rotate(-90.000000) translate(-43.299630, -78.645010) "></path>
22- <path d="M5.94160494,79.6955152 L22.7317284,79.6955152 L22.7317284,75.4934949 L10.1391358,75.4934949 L10.1391358,-0.142868687 L22.7317284,-0.142868687 L22.7317284,-4.34488889 L5.94160494,-4.34488889 L5.94160494,79.6955152 Z M29.0280247,79.6955152 L45.8181481,79.6955152 L45.8181481,75.4934949 L29.0280247,75.4934949 L29.0280247,79.6955152 Z M29.0280247,-0.0378181818 L45.8181481,-0.0378181818 L45.8181481,-4.23983838 L29.0280247,-4.23983838 L29.0280247,-0.0378181818 Z M52.1144444,79.6955152 L79.3983951,79.6955152 L79.3983951,-4.34488889 L52.1144444,-4.34488889 L52.1144444,-0.142868687 L75.2008642,-0.142868687 L75.2008642,75.4934949 L52.1144444,75.4934949 L52.1144444,79.6955152 Z" id="rect4236" fill="#888888" transform="translate(42.670000, 37.675313) rotate(-90.000000) translate(-42.670000, -37.675313) "></path>
23- <path d="M42.2502469,67.6147071 L42.2502469,-16.425697" id="path4238" stroke="#888888" stroke-width="4" transform="translate(42.774938, 25.594505) rotate(-90.000000) translate(-42.774938, -25.594505) "></path>
24- <path d="M42.2502469,90.7258182 L42.2502469,6.68541414" id="path4240" stroke="#888888" stroke-width="4" transform="translate(42.774938, 48.705616) rotate(-90.000000) translate(-42.774938, -48.705616) "></path>
25- <polygon id="rect4242" fill="#888888" transform="translate(17.522593, 14.553697) rotate(-90.000000) translate(-17.522593, -14.553697) " points="20.6707407 20.8567273 20.6707407 8.25066667 14.3744444 8.25066667 14.3744444 20.8567273"></polygon>
26- <polygon id="rect4244" fill="#888888" transform="translate(17.522593, 37.664808) rotate(-90.000000) translate(-17.522593, -37.664808) " points="20.6707407 43.9678384 20.6707407 31.3617778 14.3744444 31.3617778 14.3744444 43.9678384"></polygon>
27- <polygon id="rect4246" fill="#888888" transform="translate(17.522593, 60.775919) rotate(-90.000000) translate(-17.522593, -60.775919) " points="20.6707407 67.0789495 20.6707407 54.4728889 14.3744444 54.4728889 14.3744444 67.0789495"></polygon>
28- <ellipse id="path4208" fill="#888888" transform="translate(42.708827, 97.542545) rotate(-180.000000) translate(-42.708827, -97.542545) " cx="42.7088272" cy="97.5425455" rx="6.2962963" ry="6.3030303"></ellipse>
29- </g>
30+ <svg width="85px" height="104px" viewBox="0 0 85 104" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
31+ <title>add-pod</title>
32+ <defs></defs>
33+ <g id="Pod-creation" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
34+ <g id="003_Pod---empty-state" transform="translate(-677.000000, -320.000000)">
35+ <g id="Empty-state" transform="translate(337.000000, 320.000000)">
36+ <g id="add-pod" transform="translate(340.000000, 0.000000)">
37+ <path d="M42.2502469,126.44299 L42.2502469,42.4025859" id="path4205" stroke="#888888" stroke-width="4" transform="translate(42.774938, 84.422788) rotate(-90.000000) translate(-42.774938, -84.422788) "></path>
38+ <path d="M50.6453086,78.1197576 L35.9539506,78.1197576" id="path4207" stroke="#888888" stroke-width="4" transform="translate(43.299630, 78.645010) rotate(-90.000000) translate(-43.299630, -78.645010) "></path>
39+ <path d="M5.94160494,79.6955152 L22.7317284,79.6955152 L22.7317284,75.4934949 L10.1391358,75.4934949 L10.1391358,-0.142868687 L22.7317284,-0.142868687 L22.7317284,-4.34488889 L5.94160494,-4.34488889 L5.94160494,79.6955152 Z M29.0280247,79.6955152 L45.8181481,79.6955152 L45.8181481,75.4934949 L29.0280247,75.4934949 L29.0280247,79.6955152 Z M29.0280247,-0.0378181818 L45.8181481,-0.0378181818 L45.8181481,-4.23983838 L29.0280247,-4.23983838 L29.0280247,-0.0378181818 Z M52.1144444,79.6955152 L79.3983951,79.6955152 L79.3983951,-4.34488889 L52.1144444,-4.34488889 L52.1144444,-0.142868687 L75.2008642,-0.142868687 L75.2008642,75.4934949 L52.1144444,75.4934949 L52.1144444,79.6955152 Z" id="rect4236" fill="#888888" transform="translate(42.670000, 37.675313) rotate(-90.000000) translate(-42.670000, -37.675313) "></path>
40+ <path d="M42.2502469,67.6147071 L42.2502469,-16.425697" id="path4238" stroke="#888888" stroke-width="4" transform="translate(42.774938, 25.594505) rotate(-90.000000) translate(-42.774938, -25.594505) "></path>
41+ <path d="M42.2502469,90.7258182 L42.2502469,6.68541414" id="path4240" stroke="#888888" stroke-width="4" transform="translate(42.774938, 48.705616) rotate(-90.000000) translate(-42.774938, -48.705616) "></path>
42+ <polygon id="rect4242" fill="#888888" transform="translate(17.522593, 14.553697) rotate(-90.000000) translate(-17.522593, -14.553697) " points="20.6707407 20.8567273 20.6707407 8.25066667 14.3744444 8.25066667 14.3744444 20.8567273"></polygon>
43+ <polygon id="rect4244" fill="#888888" transform="translate(17.522593, 37.664808) rotate(-90.000000) translate(-17.522593, -37.664808) " points="20.6707407 43.9678384 20.6707407 31.3617778 14.3744444 31.3617778 14.3744444 43.9678384"></polygon>
44+ <polygon id="rect4246" fill="#888888" transform="translate(17.522593, 60.775919) rotate(-90.000000) translate(-17.522593, -60.775919) " points="20.6707407 67.0789495 20.6707407 54.4728889 14.3744444 54.4728889 14.3744444 67.0789495"></polygon>
45+ <ellipse id="path4208" fill="#888888" transform="translate(42.708827, 97.542545) rotate(-180.000000) translate(-42.708827, -97.542545) " cx="42.7088272" cy="97.5425455" rx="6.2962963" ry="6.3030303"></ellipse>
46 </g>
47 </g>
48 </g>
49- </svg>
50- <h3 class="p-heading-icon__title">You have not added any pods yet. <button class="p-button--positive is-inline ng-scope" data-ng-click="add.open = true" data-ng-if="!add.open">Add pod</button></h3>
51- </div>
52+ </g>
53+ </svg>
54+ <h3 class="p-heading-icon__title">You have not added any pods yet.</h3>
55+ <button class="p-button--positive is-inline ng-scope" data-ng-click="add.open = true" data-ng-if="!add.open">Add pod</button>
56 </div>
57 </div>
58 <div class="row">

Subscribers

People subscribed via source and target branches