Merge ~ya-bo-ng/maas:FUJ-improvements into maas:master

Proposed by Anthony Dillon
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 751a80767ab884ee858c366bba70903e84abfd89
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ya-bo-ng/maas:FUJ-improvements
Merge into: maas:master
Diff against target: 125 lines (+24/-15)
3 files modified
src/maasserver/static/partials/boot-images.html (+5/-4)
src/maasserver/static/partials/intro-user.html (+11/-7)
src/maasserver/static/partials/intro.html (+8/-4)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
MAAS Lander unittests Pending
Review via email: mp+340124@code.launchpad.net

Commit message

LP: #1751896 - Improvements to the FUJ

Description of the change

## Done
Reduced the size of the headings. Added dividers between the content and the titles. Made the success text into a list and the submit button is now full width.

## QA
- Set up a new user and login
- See that the design matches the original design: https://github.com/CanonicalLtd/MAAS-design/blob/master/First%20Use%20Journey/Flat_Visuals/001-Welcome-to-MAAS.png

Fixes https://bugs.launchpad.net/maas/+bug/1751896

To post a comment you must log in.
~ya-bo-ng/maas:FUJ-improvements updated
3a5c972... by Anthony Dillon

More improvements to the FUJ

Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/boot-images.html b/src/maasserver/static/partials/boot-images.html
2index 9fe1ad3..22603f9 100644
3--- a/src/maasserver/static/partials/boot-images.html
4+++ b/src/maasserver/static/partials/boot-images.html
5@@ -1,15 +1,16 @@
6 <form class="form">
7 <div data-ng-if="!loading" data-ng-class="{'p-strip is-bordered': design === 'page', 'p-card--highlighted col-12': design === 'card'}">
8 <div class="row">
9- <div class="col-8">
10- <h2 class="u-vertically-center"><span data-ng-if="design === 'card'"><i class="{$ getTitleIcon() $}"></i>&nbsp;</span>Ubuntu</h2>
11+ <div class="col-12">
12+ <h2 class="p-heading--four"><span data-ng-if="design === 'card'"><i class="{$ getTitleIcon() $}"></i>&nbsp;</span>Ubuntu</h2>
13+ <hr />
14 <p data-ng-if="isSuperUser() && !source.tooMany">
15 Select images and architecture to be imported and kept in sync daily. Images will be available for deploying to machines managed by MAAS.
16 </p>
17 </div>
18 </div>
19 <div class="row" data-ng-if="isSuperUser() && !source.tooMany">
20- <h3>Choose source</h3>
21+ <h3 class="p-heading--five">Choose source</h3>
22 </div>
23 <div class="row">
24 <div class="col-2">
25@@ -23,7 +24,7 @@
26 </div>
27 <div class="row" data-ng-if="isSuperUser() && !source.tooMany && showMirrorPath()">
28 <div class="col-8">
29- <h3>Mirror URL</h3>
30+ <h3 class="p-heading--five">Mirror URL</h3>
31 <p>Add the URL you want to use to select your images from.</p>
32 </div>
33 </div>
34diff --git a/src/maasserver/static/partials/intro-user.html b/src/maasserver/static/partials/intro-user.html
35index 6110b93..a4050b4 100644
36--- a/src/maasserver/static/partials/intro-user.html
37+++ b/src/maasserver/static/partials/intro-user.html
38@@ -1,12 +1,13 @@
39 <div class="p-strip" data-ng-if="!loading">
40 <div class="row">
41 <div class="p-card--highlighted col-12">
42- <h2 class="p-card__title">
43+ <h2 class="p-card__title p-heading--four">
44 <i data-ng-class="{'p-icon--success': canContinue(), 'p-icon--success-muted': !canContinue()}"></i>
45 SSH keys for {$ user.username $}
46 </h2>
47+ <hr />
48 <div class="p-card__content">
49- <p class="u-margin--top">Add multiple keys from Launchpad and Github or enter them manually.</p>
50+ <p>Add multiple keys from Launchpad and Github or enter them manually.</p>
51 <h3>Keys</h3>
52 <maas-ssh-keys></maas-ssh-keys>
53 </div>
54@@ -14,18 +15,21 @@
55 </div>
56 <div class="row">
57 <div class="p-card--highlighted col-12" data-ng-if="isSuperUser()" data-ng-class="{'u-muted': !canContinue()}">
58- <h2 class="p-card__title">
59+ <h2 class="p-card__title p-heading--four">
60 MAAS has been successfully set up
61 </h2>
62+ <hr />
63 <div class="p-card__content">
64- <p class="u-margin--top"><i class="p-icon--success"></i>Once DHCP is enabled, set your machines to PXE boot and they will be automatically enlisted in the Nodes tab.</p>
65- <p class="u-margin--top"><i class="p-icon--success"></i>Discovered MAC/IP pairs in your network will be listed on your dashboard and can be added to MAAS.</p>
66- <p class="u-margin--top u-margin--bottom"><i class="p-icon--success"></i>The fabrics, VLANs and subnets in your network will be automatically added to MAAS in Networks.</p>
67+ <ul class="p-list">
68+ <li class="p-list__item"><i class="p-icon--success"></i>Once DHCP is enabled, set your machines to PXE boot and they will be automatically enlisted in the Nodes tab.</p>
69+ <li class="p-list__item"><i class="p-icon--success"></i>Discovered MAC/IP pairs in your network will be listed on your dashboard and can be added to MAAS.</p>
70+ <li class="p-list__item"><i class="p-icon--success"></i>The fabrics, VLANs and subnets in your network will be automatically added to MAAS in Networks.</p>
71+ </ul>
72 </div>
73 </div>
74 </div>
75 <div class="row">
76- <button class="p-button--positive"
77+ <button class="p-button--positive col-12"
78 data-ng-disabled="!canContinue()"
79 data-ng-click="clickContinue()">Go to dashboard</button>
80 </div>
81diff --git a/src/maasserver/static/partials/intro.html b/src/maasserver/static/partials/intro.html
82index 0729252..4d6022f 100644
83--- a/src/maasserver/static/partials/intro.html
84+++ b/src/maasserver/static/partials/intro.html
85@@ -2,10 +2,11 @@
86 <div class="row">
87 <div class="col-12">
88 <div class="p-card--highlighted">
89- <h2 class="p-card__title">
90+ <h2 class="p-card__title p-heading--four">
91 <i data-ng-class="{ 'p-icon--success': !welcomeInError(), 'p-icon--error': welcomeInError() }"></i>
92 Welcome to MAAS
93 </h2>
94+ <hr />
95 <div class="p-card__content">
96 <div class="u-margin--top">
97 <maas-obj-form obj="maasName" manager="configManager" class="p-form p-form--stacked">
98@@ -21,9 +22,10 @@
99 <div class="row">
100 <div class="col-12">
101 <div class="p-card--highlighted">
102- <h2 class="p-card__title u-vertically-center">
103+ <h2 class="p-card__title p-heading--four">
104 <i data-ng-class="{ 'p-icon--success': !networkInError(), 'p-icon--error': networkInError() }"></i>&nbsp;Connectivity
105 </h2>
106+ <hr />
107 <ul class="p-card__content p-list">
108 <li>
109 <maas-obj-form obj="upstreamDNS" manager="configManager" class="p-form p-form--stacked">
110@@ -58,11 +60,13 @@
111 </div>
112 </div>
113 <div class="row">
114- <maas-boot-images design="'card'"></maas-boot-images>
115+ <div class="col-12">
116+ <maas-boot-images design="'card'"></maas-boot-images>
117+ </div>
118 </div>
119 <div class="row">
120 <div class="col-12">
121- <button class="p-button--positive" data-ng-disabled="!canContinue()" data-ng-click="clickContinue()">Continue</button>
122+ <button class="col-12 p-button--positive" data-ng-disabled="!canContinue()" data-ng-click="clickContinue()">Continue</button>
123 </div>
124 </div>
125 </section>

Subscribers

People subscribed via source and target branches