Merge ~ya-bo-ng/maas:fix-view-full-history into maas:master

[Anthony Dillon]

LP: #1749863 - Change the event object iterated on for the view full history of events page

The access to the events object had been changed during the Vanilla transition. I have reverted it back to how it was before and is working without errors in the console now.

[Anthony Dillon (ya-bo-ng)]

Fixes https://bugs.launchpad.net/maas/+bug/1749863

[Andres Rodriguez (andreserl)]

@Ant, please set a commit message here in LP with the following format

LP: #xxxxx - <short description>

<long description of needed >

[Andres Rodriguez (andreserl)]

Quick question inline:

review: Needs Information

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-view-full-history lp:~ya-bo-ng/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: e390cd576dbaca7d410fe5ff672d2465cd3cf340

review: Approve

[Anthony Dillon (ya-bo-ng)]

Thanks for the feedback Andres. Sorry I was rushing between meetings. I will take more time to file MP properly next time.

[Karl Williams (deadlight)]

Looks good and confirmed working.

review: Approve

[Blake Rouse (blake-rouse)]

Looks good.

review: Approve

[MAAS Lander (maas-lander)]

UNABLE TO START LANDING

STATUS: MISSING COMMIT MESSAGE

diff --git a/src/maasserver/static/partials/node-events.html b/src/maasserver/static/partials/node-events.html
index be1c99f..59e3e91 100644
--- a/src/maasserver/static/partials/node-events.html
+++ b/src/maasserver/static/partials/node-events.html
@@ -39,7 +39,6 @@
                         class="p-search-box__input" data-ng-model="search" />
                     <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search"></i></button>
                 </div>
-
                 <table id="events-listing" window-width>
                     <thead data-ng-if="windowWidth >= 769" offset="88" media-query="min-width: 768px">
                         <tr>
@@ -48,7 +47,7 @@
                         </tr>
                     </thead>
                     <tbody vs-repeat vs-scroll-parent="window">
-                        <tr data-ng-repeat="event in node.events | filter:search | orderByDate:'created':'id' track by event.id">
+                        <tr data-ng-repeat="event in events | filter:search | orderByDate:'created':'id' track by event.id">
                             <td class="col-9">
                                 <span class="p-icon--{$ event.type.level $}"></span>
                                 {$ getEventText(event) $}