Merge lp:~xzcvczx/novacut/novacut-thumbnailer-changes into lp:novacut

Proposed by xzcvczx
Status: Merged
Merged at revision: 300
Proposed branch: lp:~xzcvczx/novacut/novacut-thumbnailer-changes
Merge into: lp:novacut
Diff against target: 49 lines (+12/-18)
1 file modified
novacut-thumbnailer (+12/-18)
To merge this branch: bzr merge lp:~xzcvczx/novacut/novacut-thumbnailer-changes
Reviewer Review Type Date Requested Status
Jason Gerard DeRose Approve
Review via email: mp+140725@code.launchpad.net

Description of the change

Fixed a spelling mistake in novacut-thumbnailer
Updated novacut-thumbnailer to use argparse

To post a comment you must log in.
Revision history for this message
Jason Gerard DeRose (jderose) wrote :

Thanks, looks great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'novacut-thumbnailer'
--- novacut-thumbnailer 2012-07-16 17:47:11 +0000
+++ novacut-thumbnailer 2012-12-19 16:50:27 +0000
@@ -31,25 +31,19 @@
31from os import path31from os import path
32import json32import json
33from base64 import b64encode33from base64 import b64encode
34import optparse34import argparse
3535
3636parser = argparse.ArgumentParser(add_help=False)
37parser = optparse.OptionParser(37parser.add_argument('FILE_ID')
38 usage='%prog FILE_ID [FRAME1...]',38parser.add_argument('FRAMES', metavar='FRAME', type=int, nargs='*')
39)39args = parser.parse_args()
40(options, args) = parser.parse_args()40
4141_id = args.FILE_ID
4242
43if not args:43if not args.FRAMES:
44 print('takes at least 1 argument FILE_ID')
45 sys.exit(1)
46_id = args[0]
47
48if len(args) == 1:
49 frames = [0]44 frames = [0]
50else:45else:
51 frames = [int(f) for f in args[1:]]46 frames = args.FRAMES
52
5347
54import dbus48import dbus
55import gst49import gst
@@ -211,7 +205,7 @@
211 'data': b64encode(buf.data),205 'data': b64encode(buf.data),
212 }206 }
213 else:207 else:
214 print('got buffer for frame we arleady have', frame)208 print('got buffer for frame we already have', frame)
215 self.count += 1209 self.count += 1
216 if frame >= self.frame and self.count >= KEYFRAME:210 if frame >= self.frame and self.count >= KEYFRAME:
217 print('done', self.count, frame)211 print('done', self.count, frame)

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: