Merge lp:~xzcvczx/kicad/gerber-fix into lp:kicad/product

[xzcvczx]

Fixed the image rotation parsing code,

Before the change any image rotation that wasn't 270 degrees would show a ReportMessage.
Also made the strnicmp check the correct lengths of the numbers, as before it would only check the first 2 characters for all numbers

Fixed Gerber generation if the include extended attributes field is checked in pcbnew

[Maciej Suminski (orsonmmz)]

review: Approve

[lp:~xzcvczx/kicad/gerber-fix]

6156. By xzcvczx on 2015-09-08

Fixed RS274X image rotation parsing.

If the image was being rotated by a valid amount but not 270 degrees due to the if statements it would already report that there was an invalid value.

Also due to the strnicmp only checking the first 2 characters which was valid for 0* but not the rest of the numbers, some values would be able to work that shouldn't

[Miguel Angel Ajo (mangelajo)]

Review: Approve

nice, I didn't know we could do code reviews like this in launchpad ;)

Maciej Sumiński wrote:
> Review: Approve
>
>

[Miguel Angel Ajo (mangelajo)]

review: Approve

[Nick Østergaard (nickoe)]

review: Approve

[Wayne Stambaugh (stambaughw)]

review: Approve

[Wayne Stambaugh (stambaughw)]

I just committed this merge request in r6176. I managed to mess up the commit message with your author information instead of your commit message. Sorry about that. At least your name is attached to the commit. Thank you for contribution to KiCad.

Cheers,

Wayne

=== modified file 'gerbview/rs274x.cpp'
--- gerbview/rs274x.cpp	2015-08-23 12:35:49 +0000
+++ gerbview/rs274x.cpp	2015-09-08 12:23:37 +0000
@@ -434,11 +434,11 @@
     case IMAGE_ROTATION:    // command IR0* or IR90* or IR180* or IR270*
         if( strnicmp( text, "0*", 2 ) == 0 )
             m_ImageRotation = 0;
-        if( strnicmp( text, "90*", 2 ) == 0 )
+        else if( strnicmp( text, "90*", 3 ) == 0 )
             m_ImageRotation = 90;
-        if( strnicmp( text, "180*", 2 ) == 0 )
+        else if( strnicmp( text, "180*", 4 ) == 0 )
             m_ImageRotation = 180;
-        if( strnicmp( text, "270*", 2 ) == 0 )
+        else if( strnicmp( text, "270*", 4 ) == 0 )
             m_ImageRotation = 270;
         else
             ReportMessage( _( "RS274X: Command \"IR\" rotation value not allowed" ) );